Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Additional or custom icons #212

Open
TheAnachronism opened this issue Mar 10, 2023 · 2 comments · May be fixed by #213
Open

[Feature] Additional or custom icons #212

TheAnachronism opened this issue Mar 10, 2023 · 2 comments · May be fixed by #213
Labels
Feature New feature that will be added to the project

Comments

@TheAnachronism
Copy link

Is your feature request related to a problem? Please describe.
Currently, icons from font-awesome, material design and the internal ones are available, but it would be quite nice to also be able to use other icon libraries like bootstrap icons.

Describe the solution you'd like
I noticed that there's an IconType.Custom option, but that seems to just get ignored when using it.
I haven't been able to have a look at the source code, but maybe when using the custom or a bootstrap option, one can specify which classes should be applied on an <i> element to build the requested icon.

Describe alternatives you've considered
I'm currently fine with using the ones available, but having more options is always good.

@TheAnachronism TheAnachronism added Feature Request Request to add a new feature Triage Issue needs to be triaged labels Mar 10, 2023
@Cvijo
Copy link
Contributor

Cvijo commented Mar 10, 2023

it seems there is no implementation for the Custom type .. I suggest passing HTML string to the Icon property it gives you more options than just passing a class to tag. Some libraries need to be wrapped in tag or you might have icons as SVG images.

for example options.Icon = <img src="myIcon.svg"/>

I will make PR for this and @chrissainty can check it later

@Cvijo Cvijo linked a pull request Mar 10, 2023 that will close this issue
@TheAnachronism
Copy link
Author

Yeah, that makes sense.
Thanks for the quick answer and I hope this gets merged ^^

@chrissainty chrissainty added Feature New feature that will be added to the project and removed Feature Request Request to add a new feature Triage Issue needs to be triaged labels Jul 23, 2023
@chrissainty chrissainty changed the title [Feature Request] Additional or custom icons [Feature] Additional or custom icons Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature that will be added to the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants