-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add copyable behavior to links/addresses in blob, block and transaction tables #622
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: bf1ddaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 159 159
Lines 10772 10772
Branches 1198 1198
=======================================
Hits 9558 9558
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
332.26 KB (🔴 +86.64 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/block_neighbor |
251 B |
332.5 KB | 95.00% |
/stats |
348 KB |
680.25 KB | 194.36% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/ |
354.56 KB |
686.82 KB | 196.23% (🟢 -4.22%) |
/address/[address] |
30.04 KB |
362.3 KB | 103.51% (🟢 -3.90%) |
/blob/[hash] |
29.6 KB |
361.86 KB | 103.39% (🟢 -3.67%) |
/blobs |
80.63 KB |
412.89 KB | 117.97% (🟡 +13.66%) |
/block/[id] |
15.04 KB |
347.3 KB | 99.23% (🟢 -3.95%) |
/blocks |
78.31 KB |
410.56 KB | 117.30% (🟡 +13.65%) |
/tx/[hash] |
17.48 KB |
349.74 KB | 99.92% (🟡 +1.21%) |
/txs |
77.85 KB |
410.1 KB | 117.17% (🟡 +11.64%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
7d33d1d
to
c6bc9ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job
The CopyToClipboard
icons in the tables look slightly too large. Could we reduce their size by 1px so they match the height of a line of text?
I reduced it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist
Description
The
Copyable
component has been extended to support links. This way, we can unify all currencies with a copyable behavior into a single component.The copyable behavior has been added to all links/addresses in the
blob
,block
andtransactions
tables and its details cards.Motivation
Most of the data is shortened and you need to click and check the details to get the whole value. This way, the user can inteact directly with he table making easier its usage.
Related Issue
Closes #621
Screenshots