Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly unnecessary findParentByClassName call? #2

Open
joelip opened this issue Oct 21, 2015 · 1 comment
Open

Possibly unnecessary findParentByClassName call? #2

joelip opened this issue Oct 21, 2015 · 1 comment

Comments

@joelip
Copy link

joelip commented Oct 21, 2015

Hey @clln,

I was looking through the album.js file for Checkpoint 27 to try and help out a student who emailed me, and I noticed that there's a call to findParentByClassName() in line 83 that doesn't seem to be doing anything. Is that intentional or is it a typo (perhaps put into there for testing purposes)?

@ghost
Copy link

ghost commented Oct 21, 2015

@joelip It was for testing purposes. In making the assignment video, I had to call the function with three different sets of arguments to show that the different alerts displayed properly. The last set, which shows on line 83, didn't really need to be called, since it's actually what's in the code, but it was meant to be illustrative.

The other two sets were like (noParent, 'banana') and (child, 'banana') ... something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant