Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIP-11 breaks specification #23

Open
dskvr opened this issue Jul 25, 2024 · 2 comments
Open

NIP-11 breaks specification #23

dskvr opened this issue Jul 25, 2024 · 2 comments

Comments

@dskvr
Copy link

dskvr commented Jul 25, 2024

The pubkey value should be a string, not an object. The pubkey property is intended to be hex because the hex key does not require any decoding. Therefor, an object with the ability to set additional keys is unnecessary, out of spec and breaks validation.

From NIP-11

An administrative contact may be listed with a pubkey, in the same format as Nostr events (32-byte hex for a secp256k1 public key)."

@BlowaterNostr
Copy link
Owner

@dskvr Hey Sand, you are right. This is an accidental implementation bug that I have noticed a long time ago but since nobody is using my relay instance or implementation, I did not bother. I can make a quick fix

@dskvr
Copy link
Author

dskvr commented Aug 5, 2024

@BlowaterNostr So you know, people are using your implementation, that's how I found it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants