Plugins: Allow view specific config #201
Conversation
Add a method for view specfic configuration keys via json. The goal is to allow additional settings (i.e. 64x64 layouts) without increasing the footprint for others. A new interface called IJsonConfig defines the API to use. Both plugins and views can implement it. The plugins then forward config calls to the views to have view specific settings covered (if needed).
|
The change doen't fullfill its goal to save flash right now 👎 Default config: feature/view_config: Development: |
|
|
||
| if (false == jsonAnalogClock.isNull()) | ||
| { | ||
| jsonMerged["analogClock"] = jsonAnalogClock; |
There was a problem hiding this comment.
Did you check the REST API if you change a color value?
|
|
||
| bool DateTimeView64x64::setConfiguration(const JsonObjectConst& jsonCfg) | ||
| { | ||
| bool result = true; |
There was a problem hiding this comment.
The result will be true even if "analogClock" would be a string instead an object.
| if (false == jsonAnalogClock.isNull()) | ||
| { | ||
| jsonMerged["analogClock"] = jsonAnalogClock; | ||
| result = true; |
There was a problem hiding this comment.
Be aware, mergeConfiguration() will receive all JSON parameters as String! A conversion might be necessary here.
Using it consumes more flash than it was supposed to save.
|
@nhjschulz Please review the Swagger API update for DateTimePlugin: https://app.swaggerhub.com/apis/BlueAndi/Pixelix/1.5.0#/DateTimePlugin/getDateTimeCfg |
Add a method for view specfic configuration
keys via json. The goal is to allow additional
settings (i.e. 64x64 layouts) without increasing
the footprint for others.
A new interface called IJsonConfig defines the API to use. Both plugins and views can implement it. The plugins then forward config calls to the views to have view specific settings covered (if needed).