From e9c9f574f5bb3eaf2f387d682155cbcb2321f63d Mon Sep 17 00:00:00 2001 From: ilkilic Date: Wed, 8 May 2024 10:19:37 +0200 Subject: [PATCH] issue warning only when truncation is performed --- efel/settings.py | 3 ++- tests/test_io.py | 2 -- tests/test_settings.py | 3 ++- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/efel/settings.py b/efel/settings.py index 1ad0bee9..295f5275 100644 --- a/efel/settings.py +++ b/efel/settings.py @@ -131,7 +131,8 @@ def set_setting(self, converted_value, expected_type.__name__ ) - if expected_type is int and isinstance(new_value, float): + if expected_type is int and isinstance(new_value, float) and \ + new_value != converted_value: logger.warning(log_message) else: logger.debug(log_message) diff --git a/tests/test_io.py b/tests/test_io.py index 1e6f5d20..67e8ba77 100644 --- a/tests/test_io.py +++ b/tests/test_io.py @@ -344,8 +344,6 @@ def test_save_feature(filename, index): assert os.path.exists(filename) loaded_data = load_data(filename) - print(feature_values) - print(loaded_data) for key in feature_values.keys(): if feature_values[key] is not None and loaded_data[key]: assert np.allclose(feature_values[key], diff --git a/tests/test_settings.py b/tests/test_settings.py index e70d10a9..d4d71037 100644 --- a/tests/test_settings.py +++ b/tests/test_settings.py @@ -48,7 +48,8 @@ def test_set_setting(): @pytest.mark.parametrize("setting_name, new_value, converted_value, expected_type", [ ("Threshold", "-30.0", -30.0, float), ("strict_stiminterval", 0, False, bool), - ("initburst_freq_threshold", -50.9, -50, int) + ("initburst_freq_threshold", -50.9, -50, int), + ("initburst_sahp_start", 5.5, 5, int) ]) def test_set_setting_conversion(caplog, setting_name,