Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Preferences can use wrong value for UseOoc and disable parallelization #1035

Open
JDuffeyBQ opened this issue Aug 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@JDuffeyBQ
Copy link
Collaborator

JDuffeyBQ commented Aug 2, 2024

void Preferences::checkUseOoc()
{
  m_UseOoc = !value(k_PreferredLargeDataFormat_Key).get<std::string>().empty();
}
IParallelAlgorithm::IParallelAlgorithm()
{
#ifdef SIMPLNX_ENABLE_MULTICORE
  // Do not run OOC data in parallel by default.
  m_RunParallel = !Application::GetOrCreateInstance()->getPreferences()->useOocData();
#endif
}

This will set m_UseOoc to true if the json contains any string value. The preferences could have "In-Memory" and m_UseOoc would still be true and disable parallelization.

@JDuffeyBQ JDuffeyBQ added the bug Something isn't working label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant