Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No focus when renaming a collection with right click. #397

Open
dcallus opened this issue Aug 14, 2022 · 1 comment
Open

No focus when renaming a collection with right click. #397

dcallus opened this issue Aug 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@dcallus
Copy link
Contributor

dcallus commented Aug 14, 2022

  1. Right click a collection and press Rename.
  2. Start typing and it will not be renaming your tab, it may be typing somewhere else where you last had focus.

Make sure that a the name is in focus when renaming so you can start typing without having to click the name after pressing rename.

@dcallus dcallus added the bug Something isn't working label Aug 14, 2022
@danielfebrero danielfebrero added this to the v1.0.0-alpha milestone Aug 15, 2022
@danielfebrero danielfebrero self-assigned this Aug 15, 2022
@danielfebrero
Copy link
Member

danielfebrero commented Aug 15, 2022

Cannot reproduce, see video. I will still submit a PR that force focus.
Edit: there is already a code doing exactly this in TopBar.tsx. Not sure how I can help you with this ticket. I assign it to you.
(May be it deserves a timeout?)

useEffect(() => {
    if (isRenaming) {
      const target = document.getElementById(
        'TopBar__tab-renaming'
      ) as HTMLInputElement;
      target?.select();
    }
  }, [isRenaming]);

Recording 2022-08-15 at 18 09 48

@danielfebrero danielfebrero changed the title No focus when renaming a collection with rick click. No focus when renaming a collection with right click. Aug 17, 2022
@danielfebrero danielfebrero removed this from the v1.0.0-alpha milestone Jul 9, 2024
@danielfebrero danielfebrero added this to the 1.0.0-beta milestone Aug 26, 2024
@danielfebrero danielfebrero added wontfix This will not be worked on and removed in-1.0 1.0-beta labels Sep 28, 2024
@danielfebrero danielfebrero removed this from the 1.0.0-beta milestone Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants