Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app request: Minecraft Pi Server (fixed) #2434

Closed
2 of 3 tasks
kidmakesreal opened this issue Aug 25, 2023 · 7 comments
Closed
2 of 3 tasks

app request: Minecraft Pi Server (fixed) #2434

kidmakesreal opened this issue Aug 25, 2023 · 7 comments

Comments

@kidmakesreal
Copy link

kidmakesreal commented Aug 25, 2023

What is the name of the app?

Minecraft Pi Server

(Optional) Where is the app hosted?

No response

About the app

a simple minecraft pi server install (sorry i forgot to include the description last time)

Upload file or Add PR Link

Minecraft Pi Server.zip

Confirmations

@github-actions
Copy link
Contributor

A zipfile was found in the body of your issue.
The sha1sum of the zip was: daa39f2a7ada39b4c90fc7c896adbd41a591b43f
The contents can be previewed below:

Minecraft Pi Server/credits

https://thebrokenrail.com/ for providing the software

Minecraft Pi Server/install

#update os
sudo apt-get update

#create server folder
mkdir $HOME/mcpi_server
cd $HOME/mcpi_server

#download server
if $(uname -m | grep '64'); then
	echo "installing 64-bit"
	wget -O server.AppImage https://jenkins.thebrokenrail.com/job/minecraft-pi-reborn/job/master/257/artifact/out/minecraft-pi-reborn-server-2.4.7-arm64.AppImage
else
	echo "installing 32-bit"
	wget -O server.AppImage https://jenkins.thebrokenrail.com/job/minecraft-pi-reborn/job/master/257/artifact/out/minecraft-pi-reborn-server-2.4.7-armhf.AppImage

#make server executable
chmod +x server.AppImage

#make desktop shortcut
mkdir -p ~/.local/share/applications || error "Could not make directory"
echo "[Desktop Entry]
Name=Minecraft Pi Server
Exec=$HOME/mcpi_server/server.AppImage
Comment=Multiplayer Server
Terminal=true
Icon=$HOME/Minecraft Pi Server/mcpi_server_icon.png
Type=Application
Categories=Game;
" > ~/.local/share/applications/mcpi_server.desktop

fi

Minecraft Pi Server/website

https://unschooledinventor.com/2023/08/diy-minecraft-pi-edition-server/

Minecraft Pi Server/description

I recently installed Minecraft pi edtition on my raspberry pi and wanted to start a minecraft pi server but found little documentation and had to figure it out on my own. So i created this simple one click installer for pi-apps.

Learn how to use this software here: https://unschooledinventor.com/2023/08/diy-minecraft-pi-edition-server/

Check out my YouTube channel:
youtube.com/@kidmakesreal

Minecraft Pi Server/uninstall

rm -rf $HOME/mcpi_server/server.AppImage
rm $HOME/.local/share/applications/mcpi_server.desktop

@github-actions
Copy link
Contributor

A zipfile was found in the body of an issue comment.
The sha1sum of the zip was: ba3d1ef746b95abd424ee64753effaa8a6a5036a
The contents can be previewed below:

Minecraft Pi Server/credits

https://thebrokenrail.com/ for providing the software

Minecraft Pi Server/install

#update os
sudo apt-get update

#create server folder
mkdir $HOME/mcpi_server
cd $HOME/mcpi_server

#download server
if $(uname -m | grep '64'); then
	echo "installing 64-bit"
	wget -O server.AppImage https://github.com/NoozAbooz/mcpi-reborn-extended/releases/download/2.4.8/minecraft-pi-reborn-client_2.4.8_arm64.deb
else
	echo "installing 32-bit"
	wget -O server.AppImage https://github.com/NoozAbooz/mcpi-reborn-extended/releases/download/2.4.8/minecraft-pi-reborn-client_2.4.8_arm64.deb

#make server executable
chmod +x server.AppImage

#make desktop shortcut
mkdir -p ~/.local/share/applications || error "Could not make directory"
echo "[Desktop Entry]
Name=Minecraft Pi Server
Exec=$HOME/mcpi_server/server.AppImage
Comment=Multiplayer Server
Terminal=true
Icon=$HOME/Minecraft Pi Server/mcpi_server_icon.png
Type=Application
Categories=Game;
" > ~/.local/share/applications/mcpi_server.desktop

fi

Minecraft Pi Server/website

https://unschooledinventor.com/2023/08/diy-minecraft-pi-edition-server/

Minecraft Pi Server/description

I recently installed Minecraft pi edtition on my raspberry pi and wanted to start a minecraft pi server but found little documentation and had to figure it out on my own. So i created this simple one click installer for pi-apps.

Learn how to use this software here: https://unschooledinventor.com/2023/08/diy-minecraft-pi-edition-server/

Check out my YouTube channel:
youtube.com/@kidmakesreal

Minecraft Pi Server/uninstall

rm -rf $HOME/mcpi_server/server.AppImage
rm $HOME/.local/share/applications/mcpi_server.desktop

@kidmakesreal kidmakesreal changed the title Minecraft Pi Server Minecraft Pi Server (fixed) Aug 25, 2023
@kidmakesreal
Copy link
Author

sorry if i did it wrong im new to github

@kidmakesreal kidmakesreal changed the title Minecraft Pi Server (fixed) app request: Minecraft Pi Server (fixed) Aug 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

A zipfile was found in the body of an issue comment.
The sha1sum of the zip was: 5660b1bbcf2ec2d692419b5a7e80cffe7dda8353
The contents can be previewed below:

Minecraft Pi Server/credits

https://thebrokenrail.com/ for providing the software

Minecraft Pi Server/install

#update os
sudo apt-get update

#create server folder
mkdir $HOME/mcpi_server
cd $HOME/mcpi_server

#download server
if $(uname -m | grep '64'); then
	echo "installing 64-bit"
	wget -O server.AppImage https://github.com/NoozAbooz/mcpi-reborn-extended/releases/download/2.4.8/minecraft-pi-reborn-client_2.4.8_arm64.deb
else
	echo "installing 32-bit"
	wget -O server.AppImage https://github.com/NoozAbooz/mcpi-reborn-extended/releases/download/2.4.8/minecraft-pi-reborn-client_2.4.8_armhf.deb

#make server executable
chmod +x server.AppImage

#make desktop shortcut
mkdir -p ~/.local/share/applications || error "Could not make directory"
echo "[Desktop Entry]
Name=Minecraft Pi Server
Exec=$HOME/mcpi_server/server.AppImage
Comment=Multiplayer Server
Terminal=true
Icon=$HOME/Minecraft Pi Server/mcpi_server_icon.png
Type=Application
Categories=Game;
" > ~/.local/share/applications/mcpi_server.desktop

fi

Minecraft Pi Server/website

https://unschooledinventor.com/2023/08/diy-minecraft-pi-edition-server/

Minecraft Pi Server/description

I recently installed Minecraft pi edtition on my raspberry pi and wanted to start a minecraft pi server but found little documentation and had to figure it out on my own. So i created this simple one click installer for pi-apps.

Learn how to use this software here: https://unschooledinventor.com/2023/08/diy-minecraft-pi-edition-server/

Check out my YouTube channel:
youtube.com/@kidmakesreal

Minecraft Pi Server/uninstall

rm -rf $HOME/mcpi_server/server.AppImage
rm $HOME/.local/share/applications/mcpi_server.desktop

@theofficialgman
Copy link
Collaborator

theofficialgman commented Aug 25, 2023

I suggest you look at the other scripts if you want to make a single install file that satisfies both architectures

#download server
if $(uname -m | grep '64'); then

this is very bad. here is an example of what I am talking about

if [ $arch == 32 ];then
./node_modules/.bin/electron-builder --armv7l
elif [ $arch == 64 ];then
./node_modules/.bin/electron-builder --arm64
else
error "Failed to detect OS CPU architecture! Something is very wrong."
fi

also you don't seem to understand the concept of if/else statements. you placed the fi at the end of the file, meaning that only the "32bit" install would get the .desktop file

also, please read our wiki on creating an app as there are a multitude of issues in your scripts and I think reading our documentation will help you correct them: https://pi-apps.io/wiki/development/Creating-an-app/

@kidmakesreal
Copy link
Author

I suggest you look at the other scripts if you want to make a single install file that satisfies both architectures

#download server
if $(uname -m | grep '64'); then

this is very bad. here is an example of what I am talking about

if [ $arch == 32 ];then
./node_modules/.bin/electron-builder --armv7l
elif [ $arch == 64 ];then
./node_modules/.bin/electron-builder --arm64
else
error "Failed to detect OS CPU architecture! Something is very wrong."
fi

also you don't seem to understand the concept of if/else statements. you placed the fi at the end of the file, meaning that only the "32bit" install would get the .desktop file
also, please read our wiki on creating an app as there are a multitude of issues in your scripts and I think reading our documentation will help you correct them: https://pi-apps.io/wiki/development/Creating-an-app/

Sorry about that i did what you said here is the new file
Minecraft Pi Server.zip

@github-actions
Copy link
Contributor

A zipfile was found in the body of an issue comment.
The sha1sum of the zip was: c7e227cf2abf5b4be83a323285ef9f4bc32b1366
The contents can be previewed below:

Minecraft Pi Server/install-64

#!/bin/bash
version=2.4.8

#update os
sudo apt-get update

#create server folder
mkdir $HOME/mcpi_server
cd $HOME/mcpi_server

#download server
wget -O server.AppImage https://github.com/NoozAbooz/mcpi-reborn-extended/releases/download/${version}/minecraft-pi-reborn-server-2.4.8-arm64.AppImage || error "failed to download server"

#make server executable
chmod +x server.AppImage

#make desktop shortcut
mkdir -p ~/.local/share/applications || error "Could not make directory"
echo "[Desktop Entry]
Name=Minecraft Pi Server
Exec=$HOME/mcpi_server/server.AppImage
Comment=Multiplayer Server
Terminal=true
Icon=$HOME/pi-apps/apps/Minecraft Pi Server/icon-64.png
Type=Application
Categories=Game;
" > ~/.local/share/applications/mcpi_server.desktop

Minecraft Pi Server/install-32

#!/bin/bash
version=2.4.8

#update os
sudo apt-get update

#create server folder
mkdir $HOME/mcpi_server
cd $HOME/mcpi_server

#download server
wget -O server.AppImage https://github.com/NoozAbooz/mcpi-reborn-extended/releases/download/${version}/minecraft-pi-reborn-server-2.4.8-armhf.AppImage || error "failed to download server"

#make server executable
chmod +x server.AppImage

#make desktop shortcut
mkdir -p ~/.local/share/applications || error "Could not make directory"
echo "[Desktop Entry]
Name=Minecraft Pi Server
Exec=$HOME/mcpi_server/server.AppImage
Comment=Multiplayer Server
Terminal=true
Icon=$HOME/pi-apps/apps/Minecraft Pi Server/icon-24.png
Type=Application
Categories=Game;
" > ~/.local/share/applications/mcpi_server.desktop

Minecraft Pi Server/credits

https://github.com/NoozAbooz/ for providing the appimage

Minecraft Pi Server/website

https://unschooledinventor.com/2023/08/diy-minecraft-pi-edition-server/

Minecraft Pi Server/description

I recently installed Minecraft pi edtition on my raspberry pi and wanted to start a minecraft pi server but found little documentation and had to figure it out on my own. So i created this simple one click installer for pi-apps.

Learn how to use this software here: https://unschooledinventor.com/2023/08/diy-minecraft-pi-edition-server/

Check out my YouTube channel: https://www.youtube.com/@kidmakesreal

Minecraft Pi Server/uninstall

#!/bin/bash

#remove server app image
rm -rf $HOME/mcpi_server/server.AppImage || error "Failed to remove server.appImage"

#remove shortcut
rm -rf $HOME/.local/share/applications/mcpi_server.desktop || error "Failed to remove Minecraft Pi Server shortcut"

@kidmakesreal kidmakesreal closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants