Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Hangover #2670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add Hangover #2670

wants to merge 1 commit into from

Conversation

AndreRH
Copy link

@AndreRH AndreRH commented Oct 27, 2024

As discussed here: #2669

@Botspot
Copy link
Owner

Botspot commented Oct 27, 2024

Testing installation on our supported systems here: https://github.com/Botspot/pi-apps/actions/runs/11543239179
@theofficialgman it looks like some of the runners need fixing - something about not knowing how to uncompress an xz image.

@Botspot
Copy link
Owner

Botspot commented Oct 27, 2024

Alright, so far from the testing it looks like one issue is how the debs are compressed - they cannot use the zst compression algorithm.

@theofficialgman
Copy link
Collaborator

theofficialgman commented Oct 27, 2024

Nothing wrong with the runners (regarding tar.zst). Bullseye and older doesn't have deb tar.zst support (doesn't affect Ubuntu releases)

@theofficialgman
Copy link
Collaborator

theofficialgman commented Oct 27, 2024

Regardless though this can't be used on the Switchroot Ubuntu Jammy/Noble releases due to upstream FEX regressions (segfault on launch on versions newer than 2407)

Maybe if Hangover uses Box64 by default it could be considered.

@Botspot
Copy link
Owner

Botspot commented Oct 27, 2024

Nothing wrong with the runners (regarding tar.zst). Bullseye and older doesn't have deb tar.zst support (doesn't affect Ubuntu releases)

I should have clarified. This failure in noble-64bit appears to have happened before it reached the app-installation stage.
20241027_17h04m06s_grim

@AndreRH
Copy link
Author

AndreRH commented Oct 27, 2024

Regardless though this can't be used on the Switchroot Ubuntu Jammy/Noble releases due to upstream FEX regressions (segfault on launch on versions newer than 2407)

Maybe if Hangover uses Box64 by default it could be considered.

Hangover doesn't ship a Linux FEX build, but 2 DLLs based on FEX emulator core and I'd assume it would work on switchroot that way.
Box64 is also shipped as a DLL, but is only the default for 32-bit emulation.

@Botspot
Copy link
Owner

Botspot commented Oct 27, 2024

Could you add a bit of usage information to the description?

@theofficialgman
Copy link
Collaborator

theofficialgman commented Oct 28, 2024

Regardless though this can't be used on the Switchroot Ubuntu Jammy/Noble releases due to upstream FEX regressions (segfault on launch on versions newer than 2407)
Maybe if Hangover uses Box64 by default it could be considered.

Hangover doesn't ship a Linux FEX build, but 2 DLLs based on FEX emulator core and I'd assume it would work on switchroot that way. Box64 is also shipped as a DLL, but is only the default for 32-bit emulation.

As I said. Fex doesn't work on the mentioned systems, it segfaults on versions newer than 2407. The regression hasn't been determined yet.

@theofficialgman
Copy link
Collaborator

Nothing wrong with the runners (regarding tar.zst). Bullseye and older doesn't have deb tar.zst support (doesn't affect Ubuntu releases)

I should have clarified. This failure in noble-64bit appears to have happened before it reached the app-installation stage. 20241027_17h04m06s_grim

Seems like a temporary server error or Ubuntu removed the URL. I'll check later.

@AndreRH
Copy link
Author

AndreRH commented Oct 28, 2024

Could you add a bit of usage information to the description?

I added some examples

@AndreRH
Copy link
Author

AndreRH commented Oct 28, 2024

Regardless though this can't be used on the Switchroot Ubuntu Jammy/Noble releases due to upstream FEX regressions (segfault on launch on versions newer than 2407)
Maybe if Hangover uses Box64 by default it could be considered.

Hangover doesn't ship a Linux FEX build, but 2 DLLs based on FEX emulator core and I'd assume it would work on switchroot that way. Box64 is also shipped as a DLL, but is only the default for 32-bit emulation.

As I said. Fex doesn't work on the mentioned systems, it segfaults on versions newer than 2407. The regression hasn't been determined yet.

I'm pretty sure this is only true for the Linux FEX version, a Windows version used in Hangover is likely not affected at all. Is the Linux FEX issue for Switchroot tracked somewhere?

@Botspot
Copy link
Owner

Botspot commented Oct 28, 2024

When can the compression on the debs be fixed so that it works somewhere other than Bookworm?

@theofficialgman
Copy link
Collaborator

theofficialgman commented Oct 28, 2024

I'm pretty sure this is only true for the Linux FEX version, a Windows version used in Hangover is likely not affected at all. Is the Linux FEX issue for Switchroot tracked somewhere?

@Azkali is there an open issue for the problem I have described or is it just discord discussion? I have not had any time to bisect what causes versions newer than 2407 to segfault on Ubuntu but you seem to have trouble on every fex version on fedora.

@Azkali
Copy link

Azkali commented Oct 28, 2024

Only discussed on discord, my issue occured with some versions of FEX not all, I don't remember when it exactly happened, same thing for hangover.

@AndreRH
Copy link
Author

AndreRH commented Oct 28, 2024

When can the compression on the debs be fixed so that it works somewhere other than Bookworm?

The bullseye package is built on bullseye, and I haven't heard of issues other than on your ci. I can look into it for the next release in three weeks though.

@AndreRH
Copy link
Author

AndreRH commented Oct 28, 2024

When can the compression on the debs be fixed so that it works somewhere other than Bookworm?

The bullseye package is built on bullseye, and I haven't heard of issues other than on your ci. I can look into it for the next release in three weeks though.

I found the issue, the FEX packages are built on Ubuntu 22.04, which defaults to zstd. I can fix that easily.

@theofficialgman
Copy link
Collaborator

When can the compression on the debs be fixed so that it works somewhere other than Bookworm?

The bullseye package is built on bullseye, and I haven't heard of issues other than on your ci. I can look into it for the next release in three weeks though.

I found the issue, the FEX packages are built on Ubuntu 22.04, which defaults to zstd. I can fix that easily.

Building debs for lower versions of linux distros on a newer distro is almost always going to cause a myriad of issues. Most common being that GLIBC requirements cannot be satisfied.

Your control file is also manually created and static in the github repo. This is unacceptable and you need to generate the dependencies and their minimum versions at compile/packaging time in order to guarantee that the builds can actually run on the installed system. Use the cpack DEB generator for that (if using a fully defined cmake project) or the underlying program that cpack DEB generator relies on dpkg-shlibdeps for generating those dependencies for any existing binary.

@theofficialgman theofficialgman marked this pull request as draft October 29, 2024 13:32
@theofficialgman theofficialgman added the Upstream Bug something isn't working that can only be fixed upstream label Oct 29, 2024
@theofficialgman theofficialgman mentioned this pull request Oct 29, 2024
4 tasks
@theofficialgman
Copy link
Collaborator

theofficialgman commented Oct 29, 2024

I should have clarified. This failure in noble-64bit appears to have happened before it reached the app-installation stage.

@Botspot The error message is a misnomer. The urls changed and have been updated now.

edit: I haven't put any effort to improve/pretty the action because it will change pretty significantly once github actions linux arm runners are generally available.

@AndreRH
Copy link
Author

AndreRH commented Oct 29, 2024

When can the compression on the debs be fixed so that it works somewhere other than Bookworm?

The bullseye package is built on bullseye, and I haven't heard of issues other than on your ci. I can look into it for the next release in three weeks though.

I found the issue, the FEX packages are built on Ubuntu 22.04, which defaults to zstd. I can fix that easily.

Building debs for lower versions of linux distros on a newer distro is almost always going to cause a myriad of issues. Most common being that GLIBC requirements cannot be satisfied.

Your control file is also manually created and static in the github repo. This is unacceptable and you need to generate the dependencies and their minimum versions at compile/packaging time in order to guarantee that the builds can actually run on the installed system. Use the cpack DEB generator for that (if using a fully defined cmake project) or the underlying program that cpack DEB generator relies on dpkg-shlibdeps for generating those dependencies for any existing binary.

I'll say it again, those FEX packages contain Windows DLLs. In case you don't know what that is, consider them binary blobs, like pictures, the don't care about GLIBC, distributions or dependencies.

@theofficialgman
Copy link
Collaborator

Building debs for lower versions of linux distros on a newer distro is almost always going to cause a myriad of issues. Most common being that GLIBC requirements cannot be satisfied.
Your control file is also manually created and static in the github repo. This is unacceptable and you need to generate the dependencies and their minimum versions at compile/packaging time in order to guarantee that the builds can actually run on the installed system. Use the cpack DEB generator for that (if using a fully defined cmake project) or the underlying program that cpack DEB generator relies on dpkg-shlibdeps for generating those dependencies for any existing binary.

I'll say it again, those FEX packages contain Windows DLLs. In case you don't know what that is, consider them binary blobs, like pictures, the don't care about GLIBC, distributions or dependencies.

I was already aware those are windows dynamic libraries, not linux dynamic libraries. The wine debs however do contain linux binaries and need to have their control files generated. I missed that this is already the case https://github.com/AndreRH/hangover/blob/20da7093a53e3ca842d93ba8dca37da6b7c42c4d/.packaging/debian11/wine/debian/control#L63-L65 https://github.com/AndreRH/hangover/blob/master/.packaging/debian11/wine/Dockerfile#L9 so you are good there.

@AndreRH AndreRH force-pushed the master branch 2 times, most recently from aad2a28 to 6b5c72a Compare October 29, 2024 20:04
@theofficialgman
Copy link
Collaborator

I'm pretty sure this is only true for the Linux FEX version, a Windows version used in Hangover is likely not affected at all. Is the Linux FEX issue for Switchroot tracked somewhere?

Now tracked here FEX-Emu/FEX#4148
We (Switchroot) are still deciding on Discord how to proceed.

@AndreRH AndreRH marked this pull request as ready for review October 30, 2024 18:47
@Botspot
Copy link
Owner

Botspot commented Nov 2, 2024

The zst compression error is still an issue on Bullseye.
https://github.com/Botspot/pi-apps/actions/runs/11637595657/job/32411051344#step:3:1672

@AndreRH
Copy link
Author

AndreRH commented Nov 3, 2024

The zst compression error is still an issue on Bullseye. https://github.com/Botspot/pi-apps/actions/runs/11637595657/job/32411051344#step:3:1672

I now made a point release which solves that, 9.20.1, and pushed the change here

@theofficialgman
Copy link
Collaborator

Consider adding a pretty important wine patch that we have been carrying in our builds.
https://github.com/Pi-Apps-Coders/files/blob/main/CompileCommands/Apps/Wine%20(x64).md
It fixes (well really works around) broken wine .desktop files that can occur on some systems. More details and link to the bug report at that link.

@AndreRH
Copy link
Author

AndreRH commented Nov 24, 2024

Consider adding a pretty important wine patch that we have been carrying in our builds. https://github.com/Pi-Apps-Coders/files/blob/main/CompileCommands/Apps/Wine%20(x64).md It fixes (well really works around) broken wine .desktop files that can occur on some systems. More details and link to the bug report at that link.

now including that patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream Bug something isn't working that can only be fixed upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants