-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Hangover #2670
base: master
Are you sure you want to change the base?
add Hangover #2670
Conversation
Testing installation on our supported systems here: https://github.com/Botspot/pi-apps/actions/runs/11543239179 |
Alright, so far from the testing it looks like one issue is how the debs are compressed - they cannot use the zst compression algorithm. |
Nothing wrong with the runners (regarding tar.zst). Bullseye and older doesn't have deb tar.zst support (doesn't affect Ubuntu releases) |
Regardless though this can't be used on the Switchroot Ubuntu Jammy/Noble releases due to upstream FEX regressions (segfault on launch on versions newer than 2407) Maybe if Hangover uses Box64 by default it could be considered. |
Hangover doesn't ship a Linux FEX build, but 2 DLLs based on FEX emulator core and I'd assume it would work on switchroot that way. |
Could you add a bit of usage information to the description? |
As I said. Fex doesn't work on the mentioned systems, it segfaults on versions newer than 2407. The regression hasn't been determined yet. |
I added some examples |
I'm pretty sure this is only true for the Linux FEX version, a Windows version used in Hangover is likely not affected at all. Is the Linux FEX issue for Switchroot tracked somewhere? |
When can the compression on the debs be fixed so that it works somewhere other than Bookworm? |
@Azkali is there an open issue for the problem I have described or is it just discord discussion? I have not had any time to bisect what causes versions newer than 2407 to segfault on Ubuntu but you seem to have trouble on every fex version on fedora. |
Only discussed on discord, my issue occured with some versions of FEX not all, I don't remember when it exactly happened, same thing for hangover. |
The bullseye package is built on bullseye, and I haven't heard of issues other than on your ci. I can look into it for the next release in three weeks though. |
I found the issue, the FEX packages are built on Ubuntu 22.04, which defaults to zstd. I can fix that easily. |
Building debs for lower versions of linux distros on a newer distro is almost always going to cause a myriad of issues. Most common being that GLIBC requirements cannot be satisfied. Your control file is also manually created and static in the github repo. This is unacceptable and you need to generate the dependencies and their minimum versions at compile/packaging time in order to guarantee that the builds can actually run on the installed system. Use the cpack DEB generator for that (if using a fully defined cmake project) or the underlying program that cpack DEB generator relies on |
9aafd5b
to
484d036
Compare
@Botspot The error message is a misnomer. The urls changed and have been updated now. edit: I haven't put any effort to improve/pretty the action because it will change pretty significantly once github actions linux arm runners are generally available. |
I'll say it again, those FEX packages contain Windows DLLs. In case you don't know what that is, consider them binary blobs, like pictures, the don't care about GLIBC, distributions or dependencies. |
I was already aware those are windows dynamic libraries, not linux dynamic libraries. The wine debs however do contain linux binaries and need to have their control files generated. I missed that this is already the case https://github.com/AndreRH/hangover/blob/20da7093a53e3ca842d93ba8dca37da6b7c42c4d/.packaging/debian11/wine/debian/control#L63-L65 https://github.com/AndreRH/hangover/blob/master/.packaging/debian11/wine/Dockerfile#L9 so you are good there. |
aad2a28
to
6b5c72a
Compare
Now tracked here FEX-Emu/FEX#4148 |
The zst compression error is still an issue on Bullseye. |
I now made a point release which solves that, 9.20.1, and pushed the change here |
Consider adding a pretty important wine patch that we have been carrying in our builds. |
now including that patch |
As discussed here: #2669