Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update crsso_get_sys_cond_table() to include DCP tiers #74

Open
1 of 2 tasks
rabutler-usbr opened this issue Jul 25, 2019 · 0 comments
Open
1 of 2 tasks

Comments

@rabutler-usbr
Copy link
Contributor

rabutler-usbr commented Jul 25, 2019

update the sys_cond_rwa() too

  • potentially create multiple tables (UB and LB)
  • potentially create csv or html
  • allow the row labels to be specified via an option, so we don't have to update CRSSIO every time names slightly change
  • new row names from August 2019

Handling DCP tiers requires either a change to RWDataPlyr or modifying CRSS.
Because right now, we are determining LB tiers based on Mead PE, we have to compare if Mead is between two elevations. This is not possible in the current rwd_agg specifications, since the only valid comparisons are <, <=, >, >=, ==, !=. I suppose that you could create two different comparisons and then && them, but that is not efficient. So, RWDataPlyr could add in some "between" operators. The easier solution would be to add in binary flags to the model, which we should do anyways.

This has to be on hold until CRSS includes those outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant