Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streaming API doesn't throw 500 unless you call await stream.getFinalResponse() #1262

Open
aaronvg opened this issue Dec 18, 2024 · 0 comments
Open

streaming API doesn't throw 500 unless you call await stream.getFinalResponse() #1262

aaronvg opened this issue Dec 18, 2024 · 0 comments

Comments

@aaronvg
Copy link
Contributor

aaronvg commented Dec 18, 2024

See branch diff here where there's an integ test to repro https://github.com/BoundaryML/baml/tree/stream-should-throw

the reason is the orchestrator returns a FunctionResult (not an Error), and this FunctionResult has an item that is LLMResponseError.

The function_result.is_ok() should check if there wre other errors, not just parsing errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronvg