Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yu Cao Code Review #10

Open
daisy-cao opened this issue Nov 13, 2017 · 0 comments
Open

Yu Cao Code Review #10

daisy-cao opened this issue Nov 13, 2017 · 0 comments

Comments

@daisy-cao
Copy link

daisy-cao commented Nov 13, 2017

Structure

Firstly I would say the file construction is really good, seems everything is in great order. Readme files and comments in code are sufficient. Makes me easy to understand your project's structure and what each file is about. But one suggestion is that in your code, maybe you can add more comments in it to make it more understandable. And also that will help you guys to modify things later .

Also some name of the html files should be modified to clearify its usage.

And you should think of adding license to your project.

Code

Firstly, I think maybe you can check your python codes's style. Follow the instruction of pylint and maybe make the code more elegant.

What's more, when I'm reading the mongodb part, I find out that you are using the local host for now, this maybe the part you can improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant