Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review by Arshitha Basavaraj #11

Open
Arshitha opened this issue Nov 13, 2017 · 0 comments
Open

Code Review by Arshitha Basavaraj #11

Arshitha opened this issue Nov 13, 2017 · 0 comments

Comments

@Arshitha
Copy link

Arshitha commented Nov 13, 2017

  1. The README page of your repository is informative and structured. It helped me jog my memory about your project and understand it's purpose and motivation. The folders have a clear naming convention and each of their purposes are detailed in the README which makes it easier for the contributors interested in working on your project.

  2. The website user interface (http://medusapys.site/index.html) is particularly impressive considering you haven't made use of templates. And that it has already been hosted. However, except the provider.html page, the other pages aren't interactive yet. The "register here" and login forms aren't functional yet.

  3. In Archive/Data_Splitting_Sample, the readme.txt file contains the following text which wasn't readable. I couldn't figure out its purpose or functionality. Requires more clarity.

    {\rtf1\ansi\ansicpg1252\cocoartf1561
    {\fonttbl\f0\fswiss\fcharset0 Helvetica;}
    {\colortbl;\red255\green255\blue255;}
    {\*\expandedcolortbl;;}
      \margl1440\margr1440\vieww10800\viewh8400\viewkind0
      \pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\
      tx7200\tx7920\tx8640\pardirnatural\partightenfactor0
    

    The python code included in the same folder is time-consuming to understand for a novice in
    python. So, comments would make it more readable. Also, I'd suggest adding comments and
    description to the python code instead of creating a separate readme.txt file since reading
    comments along with the code would give it context.

  4. In the local_Web_UI folder, I noticed that you guys haven't used any bootstrap templates. Bootstrap templates make it more effective and interactive. It makes it easier for the developers to focus on funtionality of the application instead of the reinventing the wheel.

  5. When the browser is resized, the UI does change dynamically but the navbar displays all of it's content which can be compressed into bootstrap sandwich menu. These small features are easy to add using bootstrap. I'd recommend using bootstrap more extensively in your project. Link: https://getbootstrap.com/docs/3.3/components/#navbar

  6. To increase visitors conversion rate of your web application, its better to use Google or Facebook user authentication instead of creating your own which would not only be time-consuming, it'd also hurt the user conversion rates.

  7. .html files are poorly indented and sparsely commented.

@Arshitha Arshitha changed the title will update soon Code Review by Arshitha Basavaraj Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant