You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The README page of your repository is informative and structured. It helped me jog my memory about your project and understand it's purpose and motivation. The folders have a clear naming convention and each of their purposes are detailed in the README which makes it easier for the contributors interested in working on your project.
The website user interface (http://medusapys.site/index.html) is particularly impressive considering you haven't made use of templates. And that it has already been hosted. However, except the provider.html page, the other pages aren't interactive yet. The "register here" and login forms aren't functional yet.
In Archive/Data_Splitting_Sample, the readme.txt file contains the following text which wasn't readable. I couldn't figure out its purpose or functionality. Requires more clarity.
The python code included in the same folder is time-consuming to understand for a novice in
python. So, comments would make it more readable. Also, I'd suggest adding comments and
description to the python code instead of creating a separate readme.txt file since reading
comments along with the code would give it context.
In the local_Web_UI folder, I noticed that you guys haven't used any bootstrap templates. Bootstrap templates make it more effective and interactive. It makes it easier for the developers to focus on funtionality of the application instead of the reinventing the wheel.
When the browser is resized, the UI does change dynamically but the navbar displays all of it's content which can be compressed into bootstrap sandwich menu. These small features are easy to add using bootstrap. I'd recommend using bootstrap more extensively in your project. Link: https://getbootstrap.com/docs/3.3/components/#navbar
To increase visitors conversion rate of your web application, its better to use Google or Facebook user authentication instead of creating your own which would not only be time-consuming, it'd also hurt the user conversion rates.
.html files are poorly indented and sparsely commented.
The text was updated successfully, but these errors were encountered:
Arshitha
changed the title
will update soon
Code Review by Arshitha Basavaraj
Nov 13, 2017
The README page of your repository is informative and structured. It helped me jog my memory about your project and understand it's purpose and motivation. The folders have a clear naming convention and each of their purposes are detailed in the README which makes it easier for the contributors interested in working on your project.
The website user interface (http://medusapys.site/index.html) is particularly impressive considering you haven't made use of templates. And that it has already been hosted. However, except the provider.html page, the other pages aren't interactive yet. The "register here" and login forms aren't functional yet.
In Archive/Data_Splitting_Sample, the readme.txt file contains the following text which wasn't readable. I couldn't figure out its purpose or functionality. Requires more clarity.
The python code included in the same folder is time-consuming to understand for a novice in
python. So, comments would make it more readable. Also, I'd suggest adding comments and
description to the python code instead of creating a separate readme.txt file since reading
comments along with the code would give it context.
In the local_Web_UI folder, I noticed that you guys haven't used any bootstrap templates. Bootstrap templates make it more effective and interactive. It makes it easier for the developers to focus on funtionality of the application instead of the reinventing the wheel.
When the browser is resized, the UI does change dynamically but the navbar displays all of it's content which can be compressed into bootstrap sandwich menu. These small features are easy to add using bootstrap. I'd recommend using bootstrap more extensively in your project. Link: https://getbootstrap.com/docs/3.3/components/#navbar
To increase visitors conversion rate of your web application, its better to use Google or Facebook user authentication instead of creating your own which would not only be time-consuming, it'd also hurt the user conversion rates.
.html files are poorly indented and sparsely commented.
The text was updated successfully, but these errors were encountered: