You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a new issues report after last issues provided a few weeks ago. I noticed that there are several commits after last code review which is really good , meaning that you are keep working on your project.
There are some checklist for me to do this code review.
- Code formatting
I used online PEP8 checking website to check if your code meet with PEP8 requirement. Results are shown below of login_register.py file:
So, as you can see, you should do some modification about your code format.
- Architecture
It looks good to me since there are basically three layers that work for each other. But I cannot find what Local_Web_UI really looks like because there isn't any screenshots for me to review. Hope you can add them later to better illustrate your project. Besides When I looked into your websites, I noticed that websites named http://medusapys.site broke down for some reasons, while another one worked good. However, I cannot use your web application without signing up and I only found sign in page which still cannot help me to register and use your websites. I checked code about regiter.html and app.py, then I realized that you didn't have any action linked when you send post request in the first file
and it lacks some routers about register and login in second file respectively.
- Coding best practices
There do exist some hard coding in your website pages, please use constants/configuration values.
This is my code review, hope it can help!
The text was updated successfully, but these errors were encountered:
Irislpx
changed the title
Issued provided by Peixin Li
Issues provided by Peixin Li
Dec 6, 2017
This is a new issues report after last issues provided a few weeks ago. I noticed that there are several commits after last code review which is really good , meaning that you are keep working on your project.
There are some checklist for me to do this code review.
- Code formatting
I used online PEP8 checking website to check if your code meet with PEP8 requirement. Results are shown below of login_register.py file:
So, as you can see, you should do some modification about your code format.
- Architecture
It looks good to me since there are basically three layers that work for each other. But I cannot find what Local_Web_UI really looks like because there isn't any screenshots for me to review. Hope you can add them later to better illustrate your project. Besides When I looked into your websites, I noticed that websites named http://medusapys.site broke down for some reasons, while another one worked good. However, I cannot use your web application without signing up and I only found sign in page which still cannot help me to register and use your websites. I checked code about regiter.html and app.py, then I realized that you didn't have any action linked when you send post request in the first file
and it lacks some routers about register and login in second file respectively.
- Coding best practices
There do exist some hard coding in your website pages, please use constants/configuration values.
This is my code review, hope it can help!
The text was updated successfully, but these errors were encountered: