Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review 2 - Arshitha Basavaraj #18

Open
Arshitha opened this issue Dec 4, 2017 · 0 comments
Open

Code Review 2 - Arshitha Basavaraj #18

Arshitha opened this issue Dec 4, 2017 · 0 comments

Comments

@Arshitha
Copy link

Arshitha commented Dec 4, 2017

  1. The issues raised in the previous code review haven't been closed and relevant changes need to be made.

  2. Distributivecom/Archive/Distributive Computing/uploads/bigint.cpp Why does this file exist? As far as, I remember this belongs to EC602. How is this relevant to your project?

  3. Distributivecom/Archive/Distributive Computing/Code.txt This is basically the .txt version of Code.php . Since there are no comments in the code or a readme file for the folder. It's difficult to understand which particular functionality is being implemented.

  4. Even though this folder Distributivecom/Archive/Local Web UI/webUI/templates/ contains the required register/login .html files. On the deployed website, I'm unable to register our login. The submit button aren't taking the query and responding appropriately.

  5. Distributivecom/Archive/Local Web UI/webUI/connect.py inappropriate comments and doesn't seem to have been used anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant