You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Firstly y'all have over 300 commits which is commendable. Hopefully y'all are In the final stretch as its not too long before the Poster Presentation. Best of Luck!
Now coming to the code review:
Y'all havent closed the earlier Code Reviews but y'all have worked on some of the issues so thats good.
This time there was an issue in opening the Web UI and I couldn't dig deeper because I am required to log in before I can do anything on the UI.
On going onto the registration page, I couldn't register.
When I checked the code on why I couldn't, I realized that your form action is NULL, thus y'all need to fix that soon.
We were recently taught about PEP8 and Pylint, and I think y'all should update your python codes based on that ( so should we :p)
There seems to be some unnecessary files in your Github such as Bigint.cpp which doesn't have a function in your project.
Some of the comments are difficult to comprehend in connect.py.
Best of luck for the project!
The text was updated successfully, but these errors were encountered:
Firstly y'all have over 300 commits which is commendable. Hopefully y'all are In the final stretch as its not too long before the Poster Presentation. Best of Luck!
Now coming to the code review:
Y'all havent closed the earlier Code Reviews but y'all have worked on some of the issues so thats good.
This time there was an issue in opening the Web UI and I couldn't dig deeper because I am required to log in before I can do anything on the UI.
On going onto the registration page, I couldn't register.
When I checked the code on why I couldn't, I realized that your form action is NULL, thus y'all need to fix that soon.
We were recently taught about PEP8 and Pylint, and I think y'all should update your python codes based on that ( so should we :p)
There seems to be some unnecessary files in your Github such as Bigint.cpp which doesn't have a function in your project.
Some of the comments are difficult to comprehend in connect.py.
Best of luck for the project!
The text was updated successfully, but these errors were encountered: