Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review 2 : Abhi Vora #19

Open
abhivora1 opened this issue Dec 5, 2017 · 0 comments
Open

Code Review 2 : Abhi Vora #19

abhivora1 opened this issue Dec 5, 2017 · 0 comments

Comments

@abhivora1
Copy link

Firstly y'all have over 300 commits which is commendable. Hopefully y'all are In the final stretch as its not too long before the Poster Presentation. Best of Luck!

Now coming to the code review:

  1. Y'all havent closed the earlier Code Reviews but y'all have worked on some of the issues so thats good.

  2. This time there was an issue in opening the Web UI and I couldn't dig deeper because I am required to log in before I can do anything on the UI.

  3. On going onto the registration page, I couldn't register.

  4. When I checked the code on why I couldn't, I realized that your form action is NULL, thus y'all need to fix that soon.

  5. We were recently taught about PEP8 and Pylint, and I think y'all should update your python codes based on that ( so should we :p)

  6. There seems to be some unnecessary files in your Github such as Bigint.cpp which doesn't have a function in your project.

  7. Some of the comments are difficult to comprehend in connect.py.

Best of luck for the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant