New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review 2 by Fengjun Li #25

Open

Billfengjun opened this issue Dec 15, 2017 · 0 comments

Billfengjun commented Dec 15, 2017

Congratulation for u guys finish this huge work finally. Well, there are some problems I found and would like to talk.

I could not sign in or sing up on the webpage while I really need to do that to enter the webpage

2.Sometimes it is difficult for me to understand the code, so may be u guys should update your python codes based on PEP8 and Pylint.

There are some files u guys not use, maybe u can consider to delete them to make ur folder look clear.

4.In summary, I think u guys have already do a lot of work on project while some more work should be done for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment