Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows TestBed deferred deep linking doesn't work #116

Open
tadas-subonis opened this issue Jan 28, 2022 · 11 comments
Open

Windows TestBed deferred deep linking doesn't work #116

tadas-subonis opened this issue Jan 28, 2022 · 11 comments

Comments

@tadas-subonis
Copy link

I am trying to test a case when a user clicks a deep link, installs the app, and we can retrieve the link's metadata from Branch.

However, this doesn't work on our app and that also doesn't work on the provided TestBed app.

Step to reproduce:

  1. Go to link https://win32.app.link/ZIZc1yp3F9
  2. Install Branch SDK (not via link - install separately)
  3. Launch the testbed ("C:\Program Files (x86)\Branch SDK\TestBed.exe") manually
  4. There is no session data from the link I've recently clicked

image

However, the metadata retrieval works fine, if I click on the link, once the app is already installed.
image
image
image

Unfortunately, this doesn't cover one of the most important use cases for us, where we need to capture session details at the install time.

This flow works fine on iOS (Mac & iPhone) and Android. Just the Windows SDK fails to capture a recent link click.

@NidhiDixit09
Copy link
Collaborator

Can you provide some more details -

  • What version you are using ?
  • How are you creating shortURL in your own app ? What "$desktop_url" and "$canonical_url" are you passing ? Are you using the same example redirection link used in TestBed app ?
  • What browser you are using for opening link ?

@tadas-subonis
Copy link
Author

@NidhiDixit09
Hey,

I've installed branch SDK using this link: https://github.com/BranchMetrics/cpp-branch-deep-linking-attribution/releases/latest so I guess it's 1.2.4 .

I am testing the TestBed app that's provided with the SDK.

I've used the link that was provided here file:///C:/Program%20Files%20(x86)/Branch%20SDK/Welcome.html (btw, here it says that version is 1.2.2)

What browser you are using for opening link ?
Chrome

@tadas-subonis
Copy link
Author

It looks like 1.2.2 was the last version to include TestBed - there isn't one when I install 1.2.4. It probably means that I had the old version of the SDK.

Let me check with the team which version we used internally.

@tadas-subonis
Copy link
Author

@NidhiDixit09 Internally, we've used version 1.2.4 and got the same behavior.

@NidhiDixit09
Copy link
Collaborator

@tadas-subonis Hey ! I was asking about parameter values $desktop_url" and "$canonical_url" you are passing in your code.
In TestBed app its set to web page https://jdee.github.io/example-win32.html . This web page is a Branch Metrics Web SDK Example. It consumes all the deep link data. And that's why when the TestBed is installed later on, nothing is shown there. Please check attached screenshot, it shows session info which you were expecting in TestBed app.

Screen Shot 2022-01-28 at 2 57 09 PM

In your code, update $desktop_url" and "$canonical_url" to some other web page. Then you will see session info.

Let me know if you need more info.

@adrianmdumitru
Copy link

@NidhiDixit09 We found that disabling ipv6 in the browser (for firefox set network.dns.disableIPv6 in about:config) makes deferred deep linking work.

Another thing to consider, in the win32 sdk local_ip parameter will contain an ipv6 address in my case, however for android the sdk sends ipv4.

android
vs
win32

Any idea what we could change in the sdk to make it work with ipv6 as well?

@NidhiDixit09
Copy link
Collaborator

@adrianmdumitru Android doesn't support ipv6. For windows I will check and get back to you.

@adrianmdumitru
Copy link

@NidhiDixit09 any news on this?

@NidhiDixit09
Copy link
Collaborator

@adrianmdumitru Windows supports ipv6. I have tested deffered deep linking with browsers - chrome, edge and Firefox. It works with all of them.

@chanhphamgamedev
Copy link

chanhphamgamedev commented Sep 25, 2023

Hi @NidhiDixit09, any update on this issue? Our team has this problem as well. Our Win32 app cannot retrieve the link's metadata from deferred deep links on some PCs.
I tested on 3 PCs (2 Windows 11, and 1 Windows 10), and deferred deep link only works fine on Windows 10.

Steps:

  1. Uninstall the app, clear AppData, and delete the Branch registry.
  2. Click on the deferred deep link.
  3. Install and launch the app.

SDK Version
2.0.1

OS Version
Windows 11

OS Build
22631.2338

@NidhiDixit09
Copy link
Collaborator

@chanhphamgamedev The version 2.0.1 has not been tested on Windows 11. We will provide support for Windows 11 in upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants