Skip to content

Commit

Permalink
[other] [1/2] ENGMT-1983: improvements to the example page (#1103)
Browse files Browse the repository at this point in the history
# Pull Request Template

## Description

Updates a lot of the styling / look of the page to make it nicer to use.
I also added a convenience method enableTracking to the websdk. Finally
cleaned up a lot of stuff in the example.template.html

<img width="808" alt="Screenshot 2024-12-13 at 5 01 42 PM"
src="https://github.com/user-attachments/assets/cafc1432-d40f-4714-9ade-84e66ad8d4a7"
/>

<img width="901" alt="Screenshot 2024-12-13 at 5 01 33 PM"
src="https://github.com/user-attachments/assets/01768499-de40-43ce-869a-c83aefc55b8c"
/>

Next, i am thinking about what to do for the request and response stuff
at the top. I would love it if we could print out exactly what api
request happened but i need to think more about that

Fixes # (issue)

## Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration

- [ ] Unit test
- [ ] Integration test

## JS Budget Check

Please mention the size in kb before abd after this PR

| Files            | Before      | After       | 
| -----------      | ----------- | ----------- |
| dist/build.js.   |             |             |
| dist/build.min.js|             |             |

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
- [ ] I have checked my code and corrected any misspellings

## Mentions: 
List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.
  • Loading branch information
bredmond5 authored Dec 17, 2024
1 parent 299f29d commit f72a214
Showing 1 changed file with 160 additions and 159 deletions.
Loading

0 comments on commit f72a214

Please sign in to comment.