Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] fix focus getting trapped on banner #BUX-2863 #966

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

jchurin-branch
Copy link
Contributor

Pull Request Template

Description

This PR fixes the focussing not getting trapped into the banner. With this fix, the focussed elements will always be the elements inside the banner.

Fixes # (issue)
https://branch.atlassian.net/browse/BUX-2863

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link
Contributor

Test Results

114 tests   107 ✔️  48s ⏱️
    1 suites      7 💤
    1 files        0

Results for commit 0b7add7.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@8fb9e6d). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #966   +/-   ##
=========================================
  Coverage          ?   25.01%           
=========================================
  Files             ?       15           
  Lines             ?     2323           
  Branches          ?        0           
=========================================
  Hits              ?      581           
  Misses            ?     1742           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch merged commit 06108c4 into master Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants