New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipliers contract being deployed to its own address #110

Open

RonTuretzky opened this issue Dec 12, 2024 · 1 comment

Labels

good first issue

Collaborator

RonTuretzky commented Dec 12, 2024

From @bagelface

what do you guys think about the Multipliers contract being deployed to its own address?
we could also potentially call it VotingMultiplierRegistry? So it's clear it's not a multiplier itself?

The text was updated successfully, but these errors were encountered:

RonTuretzky added the good first issue label

Contributor

bagelface commented Dec 12, 2024

Refactor https://github.com/BreadchainCoop/breadchain/blob/feat/voting_multiplier/src/YieldDistributor.sol so that it no longer inherits from https://github.com/BreadchainCoop/breadchain/blob/feat/voting_multiplier/src/VotingMultipliers.sol (the voting multiplier "registry"). Instead YieldDistributor should be modified to interact with the voting multiplier registry as a standalone contract. This is a refactor so core functionality should not change. The name of the contract "VotingMultipliers" should also be changed so it's more clear what it's role is. Suggestion: "VotingMultiplierRegistry"

RonTuretzky mentioned this issue

Voting Multipliers #100

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment