Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing profile doesn't work in IE: contenteditable cannot be set on td elements in IE #51

Open
elcojacobs opened this issue Sep 2, 2015 · 1 comment
Open

Editing profile doesn't work in IE: contenteditable cannot be set on td elements in IE #51

elcojacobs opened this issue Sep 2, 2015 · 1 comment

Comments

@elcojacobs
Copy link
Member

The profile table is made editable by setting the contenteditable attribute:

$theCell.attr('contenteditable', 'true').focus(function()

In IE, this in not allowed on TD elements (table cells):

https://msdn.microsoft.com/en-us/library/ms537837(v=VS.85).aspx

This can be solved by putting a span element inside the TD, which is editable.
lukepower added a commit to lukepower/brewpi-www that referenced this issue Sep 2, 2015
@lukepower
Fixed IE issue with editing cells:
9e92e72 
Editing profile doesn't work in IE: contenteditable cannot be set on td elements in IE BrewPi#51
@lukepower lukepower mentioned this issue Sep 2, 2015
Closed
elcojacobs referenced this issue in lukepower/brewpi-www Sep 3, 2015
@lukepower
Added parseDayString function to parse strings like "1d2h30m" in prof…
58dabac 
…ile table
@lukepower
Copy link
Contributor

SHould be fixed by now in current dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elcojacobs @lukepower