Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beer Profile Graph showing wrong value if viewing from different time zone #64

Open
tgfish opened this issue Jul 11, 2016 · 1 comment

Comments

@tgfish
Copy link

tgfish commented Jul 11, 2016

When viewing my BrewPi page from a time zone other than the time zone of the physically located BrewPi the Beer Profile graph shows the incorrect temperature value.

For example:
My BrewPi is located in EDT while I am viewing my BrewPi page from CDT (1 hour behind). The Beer Profile graph shows 58.79 degrees F as the current profile value while the Current Beer Profile value (in the upper left "LCD") shows 57.6 degrees F. The 58.79 degrees F value shown in the Beer Profile graph is the correct value but for 1 hour prior.

I believe the issue stems from this line in the master branch:
https://github.com/BrewPi/brewpi-www/blob/master/js/control-panel.js#L238

and this line in the legacy branch:
https://github.com/BrewPi/brewpi-www/blob/master/js/control-panel.js#L238

Although I'm sorry I have no expertise in how to fix it.

@tgfish
Copy link
Author

tgfish commented Jul 11, 2016

Additionally, it looks like the Beer Profile values are stored without a time zone, this will cause issues if the Beer Profile is adjusted on a machine with a different time zone then the time zone of the BrewPi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant