diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 415913708..1050497d7 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -290,18 +290,25 @@ jobs: # (which is not yet generated) uses a real certificate that will be supplied by Signpath and will be suitable # for signing released versions of the application. # - # Select "release-signing" policy for things we're going to release and "test-signing" otherwise. + # Ideally we would select "release-signing" policy for things we're going to release and "test-signing" + # otherwise, according to the following logic: # - # Currently our main branch for releasing is called "develop", but we'll probably change it to "main" in the - # not too distant future. + # - Currently our main branch for releasing is called "develop", but we'll probably change it to "main" in + # the not too distant future. # - # We don't do release branches per se, but, before we do a lot of commits for a major release, we'll usually - # cut a "stable/" branch for the prior one. + # - We don't do release branches per se, but, before we do a lot of commits for a major release, we'll + # usually cut a "stable/" branch for the prior one. # - SIGNPATH_SIGNING_POLICY_SLUG: | - ${{ (github.ref == 'refs/heads/develop' || - github.ref == 'refs/heads/main' || - startsWith(github.ref, 'refs/heads/stable/')) && 'release-signing' || 'test-signing' }} + # NOTE HOWEVER that, for automated builds, we comment out this logic and always use the "test-signing" policy. + # This is because, on the free tier of SignPath, all release signings need to be manually approved. (And by + # the time a manual approval has happened, the GitHub action will have timed out waiting for it.) So, + # instead, we do our release signings via manual upload to the SignPath service. + # +# SIGNPATH_SIGNING_POLICY_SLUG: | +# ${{ (github.ref == 'refs/heads/develop' || +# github.ref == 'refs/heads/main' || +# startsWith(github.ref, 'refs/heads/stable/')) && 'release-signing' || 'test-signing' }} + SIGNPATH_SIGNING_POLICY_SLUG: 'test-signing' with: api-token: '${{ secrets.SIGNPATH_API_TOKEN }}' organization-id: '${{ vars.SIGNPATH_ORGANIZATION_ID }}' diff --git a/CHANGES.markdown b/CHANGES.markdown index 2eff6e469..9ef8d6b68 100644 --- a/CHANGES.markdown +++ b/CHANGES.markdown @@ -20,10 +20,11 @@ Bug fixes and minor enhancements. * None ### Bug Fixes -* Some input fields not wide enough on various editors [849](https://github.com/Brewtarget/brewtarget/issues/849) +* Some input fields not wide enough on various editors [849](https://github.com/Brewtarget/brewtarget/issues/849) +* Upgrade to Qt 6 [841](https://github.com/Brewtarget/brewtarget/issues/841) ### Release Timestamp -Mon, 7 Oct 2024 04:00:06 +0100 +Fri, 11 Oct 2024 04:00:07 +0100 ## v4.0.6 Bug fixes for the 4.0.5 release (ie bugs in 4.0.5 are fixed in this 4.0.6 release). diff --git a/schemas/beerxml/v1/BeerXml.xsd b/schemas/beerxml/v1/BeerXml.xsd index cd323de73..ff520baec 100644 --- a/schemas/beerxml/v1/BeerXml.xsd +++ b/schemas/beerxml/v1/BeerXml.xsd @@ -22,7 +22,7 @@ General Notes: It is not possible to validate a BeerXML 1.0 document solely with an XSD file, for reasons that are explained in the - Brewtarget C++ source code. Nevertheless, this file goes some considerable way to doing such validation. + Brewtarget/Brewken C++ source code. Nevertheless, this file goes some considerable way to doing such validation. Although they are generally helpful examples, there are some obvious errors in the BeerXML sample files downloadable from www.beerxml.com: @@ -188,7 +188,7 @@ writes out booleans in lower case. So, in the spirit of Postel's Law, we ought to support that too. And since we're being all liberal about what we accept, let's cover off "True" and "False", just in case. - --> + --> @@ -200,11 +200,12 @@ - + @@ -224,7 +225,6 @@ point number" in the standard, but this is something we may need to revisit. --> - + @@ -321,7 +329,7 @@ - + @@ -349,9 +357,9 @@ - + @@ -370,7 +378,7 @@ - + @@ -398,9 +406,14 @@ + + + + @@ -436,7 +449,7 @@ - + @@ -474,9 +487,9 @@ - + @@ -497,7 +510,7 @@ - + @@ -552,7 +565,7 @@ - + @@ -622,7 +635,7 @@ - + @@ -654,7 +667,7 @@ - + @@ -682,9 +695,9 @@ - + @@ -705,7 +718,7 @@ - + @@ -741,7 +754,7 @@ - + @@ -763,7 +776,7 @@ AFAICT this is the only record type that does not have a NAME field --> - + @@ -811,7 +824,7 @@ - + @@ -822,7 +835,8 @@ - + + @@ -839,7 +853,9 @@ - + +