Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deno #29

Open
flixx opened this issue Apr 12, 2024 · 8 comments
Open

Update Deno #29

flixx opened this issue Apr 12, 2024 · 8 comments
Labels
feature Library improvement

Comments

@flixx
Copy link

flixx commented Apr 12, 2024

Hi @Bromeon

currently, the package is dependent on Deno 0.209.0. Do you have a plan to upgrade to that?
I've read in one of your other comments somewhere, that it's difficult. Can you elaborate? What would need to get done? What could be done to help you?

Background:

We are currently stuck with an old version of js-sandbox, because we're getting some weird SEGFAULTs in some environments in v0.2.0-rc.2. We tried already hard to debug - we suspect the problem to be somewhere in the currently used Deno version.

Best,
Felix

@Bromeon
Copy link
Owner

Bromeon commented Apr 12, 2024

Last time I tried, the "op" API changed completely (which is needed to transport values back from JS to Rust). It would take some time to research how the equivalent would look in newer deno_core versions.

Some help in that regard would be appreciated, in case you want to try upgrading the version (only if you have the time, of course). It's possible that I overlooked something simple as well... 🤔

@Bromeon Bromeon added the feature Library improvement label Apr 12, 2024
@rscarson
Copy link
Contributor

rscarson commented May 6, 2024

I hope this isn't out of order but I maintain rustyscript, a similar crate that currently uses the latest version of the deno core.

It might be an option for you in the interim - migration should be fairly straightforward

@Bromeon
Copy link
Owner

Bromeon commented May 6, 2024

@rscarson How did you get the ops working in latest deno_core? (Assuming you use the same mechanism as js-sandbox) 🙂

@rscarson
Copy link
Contributor

rscarson commented May 6, 2024

@rscarson How did you get the ops working in latest deno_core? (Assuming you use the same mechanism as js-sandbox) 🙂

Have you tried the op2 macro?

You can see a macro in one of my examples here: [https://github.com/rscarson/rustyscript/blob/master/examples/ext/example_extension.rs]

And how to actually use it here: [https://github.com/rscarson/rustyscript/blob/master/examples/runtime_extensions.rs]

@Bromeon
Copy link
Owner

Bromeon commented May 22, 2024

What happened to your request to mention your crate? Did you delete the message? 🙂
I could do that; would probably batch it with the next changes (currently busy with godot-rust).

Do you know other projects that do a lightweight Rust-JS binding? I remember there was at least another crate with a similar idea.

@rscarson
Copy link
Contributor

What happened to your request to mention your crate? Did you delete the message? 🙂 I could do that; would probably batch it with the next changes (currently busy with godot-rust).

Do you know other projects that do a lightweight Rust-JS binding? I remember there was at least another crate with a similar idea.

Sure! I'd appreciate it
Sorry for the deleted message - I thought this may not have been the place to ask that

As for the 2nd question, to my knowledge Rustyscript and Js-sandbox are the only two

@pepoviola
Copy link

Hi 👋, First let me say cool projects to both 🙌! I'm also working on an small runtime (with some libs embedded) but I'm having hard time updating the version of deno_core. In my case compile ok but just hung when reach an await in the js code. Did you get something similar?

Thanks!!!

@pepoviola
Copy link

Just and small update, I managed to update the deno_core version (and the ext. versions). There was some changes by I'm happy to help here to update the version also.

Thx!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Library improvement
Projects
None yet
Development

No branches or pull requests

4 participants