Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Drop support for Node <6.6.0 #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BREAKING] Drop support for Node <6.6.0 #14

wants to merge 1 commit into from

Conversation

wojpawlik
Copy link
Contributor

Makes the package tiny and dependency-free by removing ponyfills needed only by EOL Node.js.

#13 should be released first as 1.1.5.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bc98a8c on wojpawlik:drop-old-node into ad212fc on Bruce17:master.

@Bruce17
Copy link
Owner

Bruce17 commented Mar 4, 2021

I have one doubt with only using the native timing method: performance. The benchmark tests return a bad performance for the native method using Buffer.alloc and a even worse performance using Buffer.allocUnsafe.

Therefore I have to validate the benchmark itself first and then decide on how to continue here.

Any comments on that @Drexonom ?

@Bruce17 Bruce17 requested review from Drexonom and Bruce17 March 4, 2021 12:45
@wojpawlik
Copy link
Contributor Author

How can I see the benchmark results? npm run posttest outputs nothing.

@Bruce17
Copy link
Owner

Bruce17 commented Mar 4, 2021

Matcha in Posttest ist broken for newer Node.js versions. I just tested it with some different performance testing libraries. Maybe I can upload an example soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants