PSP61 #1
Open
PSP61 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c1c01c8.
coreggon11
reviewed
Jul 20, 2023
PSPs/drafts/psp-61.md
Outdated
| fn assure_ids_are_proper() { | ||
| let contract = Contract::new(); | ||
|
|
||
| assert_eq!(contract.ownable_id(), ownable::ownable_external::TRAIT_ID); |
There was a problem hiding this comment.
it should be exposed from external so we can do ownable::TRAIT_ID
There was a problem hiding this comment.
what if we will have multiple trait_definitions in the single file?
i think the current approach is the most stress-free
Artemka374
suggested changes
Jul 25, 2023
There was a problem hiding this comment.
Can you add here some way to detect if contract support psp61? like here: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-165.md#how-to-detect-if-a-contract-implements-erc-165
In OpenBrush it's done by default, in PSP I don't think it's necessary to do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.