Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Stream instead of FileStream to upload assets #105

Open
VGrigoriev1991 opened this issue Oct 11, 2024 · 1 comment
Open

Using Stream instead of FileStream to upload assets #105

VGrigoriev1991 opened this issue Oct 11, 2024 · 1 comment

Comments

@VGrigoriev1991
Copy link
Contributor

The current implementation of SDK does not allow using a Stream instead of a FileStream to upload assets using AssetService.

The AssetService itself does nothing with the FileStream input parameter and passes it to the FileUploader, which expects the basic Stream type as input.

This functionality is very necessary when using SDK in clouds for serverless applications, when there are limits on available disk space. To use the FileStream, you must have the file directly on the disk.

The SDK is also designed in such a way that it is not possible to expand functionality of BynderClient/AssetService or use a FileUploader separately for uploading assets.

I'm suggesting a potential small change that I've already submitted as a pull request - #104.

Thanks in advance for your attention.

@ahongbynder
Copy link
Contributor

@VGrigoriev1991 merged your PR, will setup a release either next week or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants