Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter did not finished. Upload not completed #32

Open
errorswarm opened this issue Aug 26, 2020 · 2 comments
Open

Converter did not finished. Upload not completed #32

errorswarm opened this issue Aug 26, 2020 · 2 comments

Comments

@errorswarm
Copy link

I'm getting this error message for a lot JPEG images I'm uploader.

Bynder C# SDK. Fileuploader.cs Line 112

throw new BynderUploadException("Converter did not finished. Upload not completed");

Below is an example image that is giving me the exception.

1580725-JPG High

@greenrya
Copy link

@errorswarm Did you ever resolve this issue? We are seeing similar issue was checking in on how you may have worked around the issue.

@meghuizen
Copy link

meghuizen commented Apr 22, 2022

This issue does not have to deal with your image. I got them too, but this has to do with Bynder not being fast enough to pickup the uploaded assets from the Amazon S3 storage and process them. After a couple of tries, you'll get this error, but after a couple of minutes you'll notice this media is being processed and appearing in Bynder.

The issue is that the fileupload process Bynder provides, via S3 storage is fully asyncronous, with some background process Bynder uses at their side to process the media uploaded. However it does whenever it has time and resources to do this. This can be in 30 seconds or in 3 minutes. But the way it's setup in the SDK is synchronous, where it should be done for at least X tries.

You can find that waiting code, here (in HasFinishedSuccessfullyAsync of FIleUploader class):

for (int iterations = MAX_POLLING_ITERATIONS; iterations > 0; --iterations)

I've for myself changed this inside my code and it helped. But I want to refactor this still to a fully async process.

Looking more closely, the async file upload is being fixed by removing the polling option in another branch ( https://github.com/Bynder/bynder-c-sharp-sdk/tree/FS_upload_dev ):

internal async Task<SaveMediaResponse> UploadFileToNewAssetAsync(string path, string brandId, IList<string> tags)

I'm not sure if all the API calls to bynder already work, but this might mean that we don't have to poll at all anymore and so no timeout issues anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants