From 1307d7f553782316a00c9b4d05cdfafebc4c3211 Mon Sep 17 00:00:00 2001 From: TimBryanDev Date: Thu, 5 Oct 2023 16:45:30 +0100 Subject: [PATCH 1/2] :bug: z-index should not be null in Safari --- lib/Dropdown/DropdownProvider.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Dropdown/DropdownProvider.tsx b/lib/Dropdown/DropdownProvider.tsx index f228fd01d..981b271ce 100644 --- a/lib/Dropdown/DropdownProvider.tsx +++ b/lib/Dropdown/DropdownProvider.tsx @@ -1,8 +1,8 @@ import React, { createContext, - useState, Dispatch, SetStateAction, + useState, } from "react"; import cx from "classnames"; import BoundaryClickWatcher from "../BoundaryClickWatcher"; @@ -101,7 +101,7 @@ function DropdownProvider({ toggleAndSetShowContent(false); onHide(); }} - tabIndex={null} + tabIndex={-1} > {typeof children === "function" ? children({ From bfc5d7b2f0a694be9441930736904d8a4ee0e503 Mon Sep 17 00:00:00 2001 From: TimBryanDev Date: Thu, 5 Oct 2023 16:47:12 +0100 Subject: [PATCH 2/2] :label: remove null from type --- lib/BoundaryClickWatcher/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/BoundaryClickWatcher/index.tsx b/lib/BoundaryClickWatcher/index.tsx index 67c6f06b6..b0ba7b02d 100644 --- a/lib/BoundaryClickWatcher/index.tsx +++ b/lib/BoundaryClickWatcher/index.tsx @@ -58,7 +58,7 @@ interface Props { isActive?: boolean; isFocussed?: boolean; BoundaryElement?: string; - tabIndex?: number | null; + tabIndex?: number; outsideClickEventValidator?: (e?: React.MouseEvent) => boolean; children: | React.ReactNode