Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event System #1

Open
TBotV63 opened this issue Oct 24, 2014 · 3 comments
Open

Event System #1

TBotV63 opened this issue Oct 24, 2014 · 3 comments
Assignees
Labels

Comments

@TBotV63
Copy link
Contributor

TBotV63 commented Oct 24, 2014

Add an event system and events.

Events:

  • WarbandCreationEvent
  • WarbandDeletionEvent
  • LandClaimEvent
  • LandUnclaimEvent
  • PlayerJoinEvent
  • PlayerPartEvent
  • StatusCreatedEvent
  • StatusDeletedEvent
  • PlayerPromotionEvent
  • PlayerDemotionEvent
@AtriusX AtriusX added the Task label Oct 24, 2014
@TBotV63 TBotV63 self-assigned this Oct 24, 2014
@FerusGrim
Copy link
Contributor

A few things:

  • I think, internally, we should refer to Warbands as Groups.
  • To reduce redundancy, we can remove 'Player' from most (if not all) events. We're not having Zombies join any Groups, after all.
  • Not only will the above get rid of some redundancy, but it'll lessen confusion. PlayerJoinEvent, for instance, is likely to be confusing (or even conflicting) with an event in the SpongeAPI.

New List Ideas:

  • GroupCreationEvent
  • GroupDeletionEvent
  • LandClaimEvent
  • LandUnclaimEvent
  • GroupJoinEvent
  • GroupPartEvent
  • StatusCreatedEvent
  • StatusDeletedEvent
  • GroupPromotionEvent
  • GroupDemotionEvent

Also, as far as "add[ing] an event system". I'm not sure we should do this. Sponge will already have an event system we can add onto. Creating our own would be akin to recreating the wheel.

@FerusGrim FerusGrim assigned FerusGrim and TBotV63 and unassigned TBotV63 and FerusGrim Oct 31, 2014
@TBotV63
Copy link
Contributor Author

TBotV63 commented Oct 31, 2014

Okay, I think we should post our events over the SpongeAPI event system.

@TBotV63
Copy link
Contributor Author

TBotV63 commented Nov 1, 2014

Dramatic change.

We can't even use that... We're building against bukkit for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants