Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodePort not really optional on NodePort Service #30

Open
D3nn opened this issue Dec 3, 2018 · 1 comment
Open

NodePort not really optional on NodePort Service #30

D3nn opened this issue Dec 3, 2018 · 1 comment
Labels
area.ui Issue in the UI area. bug Something isn't working

Comments

@D3nn
Copy link

D3nn commented Dec 3, 2018

(Found on SaaS yipee: staging2)
Supplying an empty Node port in a service port where the service is of type LoadBalancer or likely NodePort generates a "Teapot" error in the backend. This is because it tries to parseInt a value of "null." Looks like the same bug exists in the yipee-tiyay version of the converter as well.
@D3nn D3nn added area.api API issues area.converter bug Something isn't working labels Dec 3, 2018
@jrryjcksn
Copy link
Collaborator

Reassigning to UI as the value being passed in for nodePort is the string "null". Either an actual null or an empty string works correctly.

markemeis pushed a commit that referenced this issue Dec 14, 2018
@jd3quist
Merge pull request #30 from yipeeio/build-fixes
32c04da 
fix api test and fail top-level build on errors
@markemeis markemeis added area.ui Issue in the UI area. and removed area.api API issues area.converter labels Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area.ui Issue in the UI area. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bl8nr @markemeis @D3nn @jd3quist @jrryjcksn @andrewcopley