Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unselected Profiles Appear Dark in Light Theme #620

Closed
ganidande905 opened this issue Dec 24, 2024 · 3 comments · Fixed by #621
Closed

Bug: Unselected Profiles Appear Dark in Light Theme #620

ganidande905 opened this issue Dec 24, 2024 · 3 comments · Fixed by #621
Labels
bug Something isn't working

Comments

@ganidande905
Copy link
Contributor

ganidande905 commented Dec 24, 2024

Description

In the Light Theme, unselected profiles appear dark, which disrupts the UI's consistency and theme aesthetics. This behavior does not occur in the Dark Theme, where unselected profiles display correctly.

Steps to Reproduce

  • Switch to the Light Theme in the application.
  • Create a new profile.
  • Observe the appearance of unselected profiles.

In the Light Theme, unselected profiles appear dark, which negatively impacts the theme's visual balance.
In the Dark Theme, unselected profiles are displayed correctly and do not have this issue.

Screenshots

Light theme

Screenshot_2024-12-24-20-56-39-61_a53a7893e903efe7d38a33066bfd52df

Dark theme

Screenshot_2024-12-24-20-56-46-49_a53a7893e903efe7d38a33066bfd52df

@ganidande905 ganidande905 added the bug Something isn't working label Dec 24, 2024
@ganidande905
Copy link
Contributor Author

Hey @AryanSarafDev could you assign this issue to me

@c-o-d-e-y-o-d-a
Copy link

Hey @AryanSarafDev could you assign this issue to me
Hello @ganidande905 and @AryanSarafDev , I raised a similar issue #610 and was assigned to work on that issue, I am changing the whole UI of this section to make it more intuitive to use and the changes @ganidande905 recommend, I am already working working on them as they are part of the bigger issue.

@ganidande905
Copy link
Contributor Author

Hey @c-o-d-e-y-o-d-a ,
I've already raised a PR on this issue
And I've gone through the issue you've said
And that's actually not an issue because that's a part of the design
When we swipe right to look at all profiles the current profile you are in is highlighted by full colour
But when you minimise the profile section the current profile is displayed by slight green on the left as a part of ui so I don't see the necessity of working on that issue
And I've also made another pr #619
Which brings responsiveness throughout the app
And coming to your mention on changing the whole ui part , I think it's better if we just follow the app theme
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants