Improve perfomance of node network functions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance improved by retrieving a neutron port directory and avoiding later API calls; and by parallelizing port forwarding queries.
tzumainn
force-pushed
the
node-network-list
branch
from
2c0f7b7 to
cb055fb
Compare
DanNiESh
reviewed
Nov 15, 2024
| @@ -85,22 +98,19 @@ def get_networks_from_port(connection, port, networks_dict={}, floating_ips_dict | |||
| parent_network = connection.network.get_network(network=port.network_id) | |||
|
|
|||
| if port.trunk_details: | |||
| with concurrent.futures.ThreadPoolExecutor() as executor: | |||
There was a problem hiding this comment.
Why the concurrent.futures.ThreadPoolExecutor() need to be removed? Does it lead to slower execution with ThreadPoolExecutor?
There was a problem hiding this comment.
Oh, simply because it should no longer be necessary. The port dictionary should contain all the ports the user can see, so the API query should never be made. The if/else is still there mostly as a just-in-case thing - similar to what the code does with networks - but uncluttering the code feels like a win to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improved by retrieving a neutron port directory and avoiding later API calls; and by parallelizing port forwarding queries.