Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CSVs for prepaid group billing #80

Open
QuanMPhm opened this issue Aug 14, 2024 · 7 comments
Open

Add new CSVs for prepaid group billing #80

QuanMPhm opened this issue Aug 14, 2024 · 7 comments
Assignees
Milestone

Comments

@QuanMPhm
Copy link
Contributor

QuanMPhm commented Aug 14, 2024

As part of implementing prepaid group billing, several CSVs containing information needed for prepaid group billing needs to be stored in a private Github repo, as well as in several backup locations. These CSVs include:

  • Prepaid Group Debit Ledger: Containing all debits for each prepaid group every month
  • Prepaid Group Credit Ledger: Containing all credits for each group every month
  • Prepaid Group Contacts: Has group name, contact email, and whether they are MGHPCC managed
  • Prepaid Group Projects: Containing information on the projects in each prepaid group

We need to decide where these files will be stored. @knikolla @naved001 @joachimweyl I will wait for your thoughts before continuing.

@QuanMPhm QuanMPhm self-assigned this Aug 14, 2024
@joachimweyl
Copy link
Contributor

What do people think of

  1. CCI-MOC/prepaid-group-billing
  2. CCI-MOC/prepaid-group-tables
  3. CCI-MOC/prepaid-billing
  4. CCI-MOC/prepaid-tables
  5. Rename non-billable-projects to private-billing-tables and share all our private tables in that repo

@knikolla
Copy link
Contributor

@joachimweyl I'd go with 5, I don't see why this needs to be a separate repo. So renaming nonbillable to something more generic is the best solution.

@joachimweyl
Copy link
Contributor

@naved001 to cover all our bases, is any code using CCI-MOC/non-billable-projects hardcoded that will need to be changed?

@knikolla
Copy link
Contributor

@naved001 to cover all our bases, is any code using CCI-MOC/non-billable-projects hardcoded that will need to be changed?

@joachimweyl GitHub maintains redirects after a repo is renamed, so nothing will break.

From renaming a repository

In addition to redirecting web traffic, all git clone, git fetch, or git push operations targeting the previous location will continue to function as if made on the new location.

@naved001
Copy link
Collaborator

is any code using CCI-MOC/non-billable-projects hardcoded that will need to be changed?

no, the code doesn't refer to github directly, it just expects the file to be passed to it via command line.

@QuanMPhm
Copy link
Contributor Author

@knikolla @naved001 Should I write a separate issue to decide the backup locations for these files?

@QuanMPhm
Copy link
Contributor Author

@knikolla @naved001 @joachimweyl Do you have any input on the above question, since we're currently making progress on refactoring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants