Added NA check for empty 2nd Month Used field
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the `2nd Month Used` field for some PIs are empty in the old PI file, not having the NA check would result in an error In the future, all PI entries should no longer have empty fields, given how this script initilizes new PI entries, so this change might not be completely nessecary. Nonetheless, it's good to check all our bases?
naved001
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the
2nd Month Usedfield for some PIs are empty in the old PI file, not having the NA check would result in an errorIn the future, all PI entries should no longer have empty fields, given how this script initilizes new PI entries, so this change might not be completely nessecary. Nonetheless, it's good to check all our bases?