Refactored the HU-BU invoice #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
approved these changes
Jul 16, 2024
naved001
approved these changes
Jul 25, 2024
|
@QuanMPhm what are the next steps to getting this merged? |
|
@joachimweyl This PR is dependent on #61, so I'll have to wait for that to resolve first. |
Aside from the addition of `hu_bu_invoice.py`, I decided to cache the results of `get_invoice_bucket()` using functools
QuanMPhm
force-pushed
the
52.3/refactor_HU_BU
branch
from
a39e370 to
6b65e49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68. Not necessarily dependent on #61, but is part of the overall refactor process. Aside from the addition of
hu_bu_invoice.py, I decided to cache the results ofget_invoice_bucket()using functoolsWhile refactoring, I noticed that I didn't add code to upload the BU Internal invoice to S3, and also forgot to remove some functions from
process_report.pythat have been moved toutils.py. @naved001 @knikolla Should these be part of a separate commit or issue?