Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance]: Maintainer in need #69

Open
130s opened this issue Feb 15, 2021 · 20 comments
Open

[Maintenance]: Maintainer in need #69

130s opened this issue Feb 15, 2021 · 20 comments

Comments

@130s
Copy link
Collaborator

130s commented Feb 15, 2021

Problem

I joined the maintenance of scan_tools repo when I was an active user and the maintainers back then seemed to be busy. Unfortunately I no longer am the user. AFAICT, other then-maintainers have not been active (checking in @ubuntuslave). So I'd call this repo is nearly unmaintained (I just made first releases into newer ROS distro #67 (comment), where I claim as unmaintained).

Discussion

Unless the current maintainers can be back active, I'd suggest calling for maintainership.

If no maintainer shows up, one thing to continue making the software alive is to register "Orphaned packages". With that, at least someone will continue making releases (review PRs, bugfix are not guaranteed IIUC).

@130s
Copy link
Collaborator Author

130s commented Apr 30, 2021

Checking in again. If I hear none then I'll start "Orphaned package" process.

Care to chime in @ubuntuslave or any others who've contributed to this repo?

@sisaha9
Copy link

sisaha9 commented Jul 5, 2021

Maybe check over in ROS Discourse?

@cst0
Copy link
Collaborator

cst0 commented Jul 19, 2021

Hey @130s -- I've started to rely on this package on a handful of projects here in the lab, am pretty comfortable with ROS, and have a small amount of experience pushing stuff to the ROS repositories. If you're still looking for a maintainer, I'm willing to volunteer.

@130s
Copy link
Collaborator Author

130s commented Jul 12, 2022

@cst0 Sorry for the late response. Are you still interested in joining the maintainership?

@solutiongeek2022 I'm not sure how your comment is relevant to the context.

@cst0
Copy link
Collaborator

cst0 commented Jul 12, 2022

Hi @130s -- no worries on the timing. Yes, I'm still happy to help out.

@130s
Copy link
Collaborator Author

130s commented Jul 15, 2022

@cst0 Great! First would you helping out by joining the discussion that needs opinions/approvals AndreaCensi/csm#33 (comment)?

@130s
Copy link
Collaborator Author

130s commented Feb 19, 2023

@ubuntuslave If you're still around, I have 2 favors to ask. Would you mind:

  • changing the default branch to ros1?
  • adding @cst0 write access?
    • @cst0 Sorry took me awhile to respond. Are you still up for joining maintainership?

@cst0
Copy link
Collaborator

cst0 commented Feb 20, 2023

Are you still up for joining maintainership?

Sure!

@130s
Copy link
Collaborator Author

130s commented Feb 24, 2023

Thanks @cst0!

@ubuntuslave If you're still around, I have 2 favors to ask. Would you mind:

  • changing the default branch to ros1?
  • adding @cst0 write access?

@ubuntuslave Can you also give @malban write access? He's recently contributed PRs that require in-depth understanding of the codebase, and he agreed offline to co-maintain the repo.

(I have a write access but don't have a maintainer access on this repo, so if we don't hear back and don't have these requests addressed, we might have to fork the repo somewhere else so that the new maintainers would have maintainer access (which happens a lot in OSS world, and original authors' credit remains in a new repo)).

@130s
Copy link
Collaborator Author

130s commented May 23, 2023

I emailed @ccny-ros-pkg to request giving me an admin access (once I get it, I'll add maintainers, as well as making new branches for ROS2).

@cst0
Copy link
Collaborator

cst0 commented May 23, 2023

Great!

@130s
Copy link
Collaborator Author

130s commented Jun 2, 2023

No response. I emailed the lab's PI, Dr. Xiao.

@ehoxha91
Copy link
Member

ehoxha91 commented Jun 12, 2023

Hi,

I'll give you guys write access. Sorry for not checking this earlier. However, it will take some time. I have permission issues myself, whenever I'm using another PC outside CCNY Robotics Lab. Thus, give me some time to go in the lab (I work from home), and I'll take care of this.

-- Ejup

Actually, it seems I just fixed the issue.

@130s
Copy link
Collaborator Author

130s commented Jun 12, 2023

@ehoxha91 Thanks, I now do see "Settings" menu, however, inside of it, I see very minimum menus. E.g. I need to see "branch" menu (to change the default branch) but I don't see it. I also don't see the list of other maintainers.

Looking at Repository roles for an organization page, "maintainer" falls short for the maintenance duties we're talking about. I guess we'll need "admin". Would you mind considering that?

@130s 130s reopened this Jun 12, 2023
@130s
Copy link
Collaborator Author

130s commented Jul 1, 2023

Waiting for approval for full admin privilege.

Meanwhile @cst0 @malban you two also have limited maintainer access. Maybe update maintainer section in package.xml?

@130s
Copy link
Collaborator Author

130s commented Aug 24, 2023

Still waiting, pinged the PoC again.

@130s
Copy link
Collaborator Author

130s commented Oct 4, 2023

I asked one last time. If I don't hear back I'll suggest plan-B (fork and move the upstream there).

@ehoxha91
Copy link
Member

ehoxha91 commented Oct 6, 2023

Hello everyone, will handle this today.

@ehoxha91
Copy link
Member

ehoxha91 commented Oct 6, 2023

Isaac, your role is updated to Admin.

@130s
Copy link
Collaborator Author

130s commented Oct 10, 2023

@ehoxha91 Thank you so much, I confirmed that I have maintenance access.

@cst0 @malban I gave you two a maintenance access as well. Would either of you mind updating package.xml (which ros.org refers to as the source of maintainers' contact info) with your info? With that done I think we can close this ticket IMO.

I don't foresee actively using nor maintaining this repo for now. I can be a backup (like I did to take care of maintenance status) but I'd like to count on either of you for the maintenance if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@130s @ehoxha91 @cst0 @sisaha9 and others