From d61edf46666bdc865dbcd29bc2c1c85d81efeaeb Mon Sep 17 00:00:00 2001
From: CCXXXI <ccxxxi@qq.com>
Date: Mon, 11 Jan 2021 01:07:45 +0800
Subject: [PATCH] denying writes to executables

---
 src/userprog/process.c | 19 +++++++++++++------
 src/userprog/process.h |  1 +
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/src/userprog/process.c b/src/userprog/process.c
index 170f5e7..03b28d0 100644
--- a/src/userprog/process.c
+++ b/src/userprog/process.c
@@ -24,7 +24,7 @@ static struct list all_list;
 static thread_func start_process NO_RETURN;
 static bool load(const char *cmdline, void (**eip)(void), void **esp);
 static void process_load_fail(void);
-static void process_load_success(void);
+static void process_load_success(const char *cmd);
 
 typedef void (*ret_addr_t)(void);
 typedef union
@@ -111,16 +111,16 @@ static void start_process(void *file_name_)
     char *cmd = strtok_r(file_name, " ", &save_ptr);
     success = load(cmd, &if_.eip, &if_.esp);
 
-    /* If load successed, pass arguments. */
     if (success)
+    {
         if_.esp = arg_pass((esp_t)if_.esp, cmd, save_ptr);
+        process_load_success(cmd);
+    }
 
     /* Free file_name whether successed or failed. */
     palloc_free_page(file_name);
 
-    if (success)
-        process_load_success();
-    else
+    if (!success)
         process_load_fail();
 
     /* Start the user process by simulating a return from an
@@ -227,6 +227,11 @@ void process_exit(void)
     struct process *self = cur->process;
     self->thread = NULL;
     self->status = PROCESS_EXITED;
+
+    ASSERT(self->file != NULL);
+    file_allow_write(self->file);
+    file_close(self->file);
+
     sema_up(&self->sema_wait);
 }
 
@@ -634,11 +639,13 @@ static void process_load_fail(void)
 }
 
 /* Set process status when load successed. */
-static void process_load_success(void)
+static void process_load_success(const char *cmd)
 {
     struct process *self = thread_current()->process;
 
     self->status = PROCESS_NORMAL;
+    self->file = filesys_open(cmd);
+    file_deny_write(self->file);
 
     sema_up(&self->sema_load);
 }
diff --git a/src/userprog/process.h b/src/userprog/process.h
index 143b256..c34403b 100644
--- a/src/userprog/process.h
+++ b/src/userprog/process.h
@@ -33,6 +33,7 @@ struct process
     struct semaphore sema_wait; /* Parent block on this while waiting. */
     struct list files;          /* Opening files. */
     int fd;                     /* Max file descriptor num. */
+    struct file *file;          /* Executable file loaded by self. */
 };
 
 void process_init(void);