-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OML mappings #15910
Update OML mappings #15910
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Integration Test Results 54 files +1 54 suites +1 29m 33s ⏱️ + 1m 31s Results for commit fa0014e. ± Comparison against base commit 1bf38e8. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
46cedd1
to
15e4232
Compare
Quality Gate failedFailed conditions |
436521e
to
91e4dce
Compare
91e4dce
to
24fe148
Compare
...esources/metadata/hl7_mapping/OML_O21/base/order/observation-request/observation-request.yml
Show resolved
Hide resolved
...e-router/src/testIntegration/kotlin/datatests/mappinginventory/catchall/omlo21/OMLO21Full.kt
Show resolved
Hide resolved
...in/datatests/mappinginventory/catchall/orcobr/ORCOBRToServiceRequestDiagnosticReportTests.kt
Show resolved
Hide resolved
...er/src/testIntegration/resources/datatests/mappinginventory/catchall/omlo21/oml_o21-full.hl7
Outdated
Show resolved
Hide resolved
@@ -109,23 +107,16 @@ | |||
} | |||
], | |||
"name" : "NATUS", | |||
"endpoint" : "urn:dns:natus.health.state.mn.us", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#TODO: I arrived at the contents of this file by using the fhirdata cli tool to generate the fhir from the expected hl7. I'm not sure how important some of these removed fields are to ETOR but I imagine they would be delighted if those one day showed up in the HL7 (and thus good to preserve in this file). When logging the ticket for the OML second pass I will also go through and see if any of these are low hanging fields to add that are mapped in the mapping inventory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple points here: Logged a ticket for the follow up OML items. Posted in the ETOR channel to alert them to the changes coming down the pipe. Also remembered that a number of fields are enriched from ETOR-TI itself.
prime-router/src/testIntegration/resources/datatests/FHIR_to_HL7/sample_OML_20230831-0001.fhir
Show resolved
Hide resolved
For some reason after pushing the last commit to fix the build, GitHub decided the backend didn't need to be built :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to post these comments on Friday.
prime-router/metadata/HL7/catchall/hl7/codesystem/ExtensionUrlMapping.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic stuff! Only comment would be a few new test cases or test enhancements
prime-router/metadata/HL7/catchall/hl7/codesystem/ExtensionUrlMapping.yml
Outdated
Show resolved
Hide resolved
...e-router/src/testIntegration/kotlin/datatests/mappinginventory/catchall/omlo21/OMLO21Full.kt
Show resolved
Hide resolved
prime-router/metadata/HL7/catchall/hl7/codesystem/ExtensionUrlMapping.yml
Outdated
Show resolved
Hide resolved
prime-router/src/main/resources/metadata/hl7_mapping/OML_O21/base/patient/patient-base.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and new tickets appear ready for refinement, great work!
* Update OML FHIR -> HL7 Mappings * Update OML HL7 -> FHIR mappings * Add OML mapping integration tests * Removing unused FHIR -> HL7 mappings * Adding OML to CWE/CE override * Adjusting existing tests * Adding tests for new misc mappings * Update existing OML integration tests * Fixing integration tests after rebase * expected oru changes * Specimen.collection conditional update * Updating formatting for cleaner diff * Missed e2e test updates * PRT <-> Device mappings will be taken care of in the next PR * Changed line endings from CRLF to LF * Removing OML use of HL7v2Name url
This PR updates the OML mappings to use the new catchall mappings.
Test Steps:
./gradlew :prime-router:testIntegration --tests "gov.cdc.prime.router.datatests.mappinginventory.omlo21.OMLO21Full" -Pforcetest
./gradlew :prime-router:testIntegration --tests "gov.cdc.prime.router.datatests.TranslationTests" -Pforcetest
Changes
hl7_mapping/common
;hl7_mapping/v251
; etc.)ServiceRequest.specimen
andServiceRequest.supportingInfo
were added to support this.Specimen.collection
andPatient.relationship
were updated as well.translation-test-config.csv
to reflect updates in the mappings.fhir
file in the FHIR -> HL7 scenario will need to be verified and communicated with ETOR to ensure no breaking changes have been made. The significant differences here reflect the new and different fields being mapped in the OML HL7 -> FHIR conversion. #TODOChecklist
Testing
./prime test
or./gradlew testSmoke
against local Docker ReportStream container?npm run lint:write
?Process
To Be Done
Follow up issues still need to be logged:
fhirdata
cli tool which causes an exception when attempting to generate fhir data from a hl7 file. Unit tests should also be created for this command.NOT_NULL
vsNOT NULL
).hl7v2Name
(which used to be a valid extension url) from our code base.