Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engagement/hl7data improvements #17261

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Conversation

oslynn
Copy link
Collaborator

@oslynn oslynn commented Feb 4, 2025

This PR adds enrichment schema to suppress XTN-12 from PID-13, ORC-14, ORC-23, OBR-17.

Test Steps:

  1. ./gradlew package
  2. ./prime fhirdata --input-file "./single-entry/1/1.fhir" --sender-schema classpath:/metadata/fhir_transforms/senders/SimpleReport/simple-report-sender-transform.yml --enrichment-schemas "classpath:/metadata/fhir_transforms/common/suppress-xtn-12.yml" --receiver-schema classpath:/metadata/hl7_mapping/receivers/STLTs/WI/WI-receiver-transform.yml --output-format HL7 --output-file "./single-entry/1/1_from_fhir.hl7"

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

@oslynn oslynn added the onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS. label Feb 4, 2025
@oslynn oslynn self-assigned this Feb 4, 2025
@oslynn oslynn marked this pull request as ready for review February 4, 2025 19:57
@oslynn oslynn requested a review from a team as a code owner February 4, 2025 19:57
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Results

1 287 tests  +8   1 283 ✅ +8   8m 11s ⏱️ +34s
  168 suites ±0       4 💤 ±0 
  168 files   ±0       0 ❌ ±0 

Results for commit 386c39b. ± Comparison against base commit 51a9ff2.

This pull request removes 1 and adds 9 tests. Note that renamed tests count towards both.
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test mojuroTimezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test ChuukTimezone for Micronesia timezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test KosraeTimezone for Micronesia timezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test MajuroTimezone for Marshall Island timezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test Northern_Mariana_IslandsTimezone for Northern Mariana Islands timezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test PauluTimezone for Palau timezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test PohnpeiTimezone for Micronesia timezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test Puerto_RicoTimezone for Puerto Rico timezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.CustomTranslationFunctionsTest ‑ test US_Virgin_IslandsTimezone for US Virgin Island timezone with convertDateTimeToHL7()
gov.cdc.prime.router.fhirengine.engine.FhirReceiverFilterTests ‑ fail - receiver fhir routing filter fails()

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Integration Test Results

 60 files  ±0   60 suites  ±0   43m 34s ⏱️ +23s
428 tests ±0  408 ✅  - 10  10 💤 ±0  10 ❌ +10 
431 runs  ±0  411 ✅  - 10  10 💤 ±0  10 ❌ +10 

For more details on these failures, see this check.

Results for commit 386c39b. ± Comparison against base commit 51a9ff2.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants