Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --scenarios flag #8

Closed
arik-shurygin opened this issue Nov 7, 2024 · 4 comments
Closed

add --scenarios flag #8

arik-shurygin opened this issue Nov 7, 2024 · 4 comments

Comments

@arik-shurygin
Copy link
Collaborator

arik-shurygin commented Nov 7, 2024

add a --scenarios flag which takes a list of string scenario names and to allow users to specify multiple scenarios per state. The launch_experiment script should then be able to pass along each scenario to the run_task.py runner script via the --scenario flag on the runner.

This will expand the launch_experiment's functionality and make it less likely that users need to write their own custom versions of the script.

(edit: the following feature is now located in #9 )
Can also introduce an explicit mode which instead reads in a CSV that defines each task and the keywords passed along to it. For example, if your run_task.py script takes in 2 arguments --state, --scenario, and the obligatory --jobid you could provide a CSV with the two changing columns columns state, scenario and then each row of that CSV could be launched as its own task. Since the user already provides the --jobid flag to the launcher a similar row is not needed for that argument. I am curious if you would use such a mode @kokbent

@kokbent
Copy link
Collaborator

kokbent commented Nov 7, 2024

CSV idea is pretty neat 🤔 although it's seldom that we would run differential scenarios for each state at the moment... I think there's a good chance I would use it to be sure the book-keeping is right but not frequently...

@kokbent
Copy link
Collaborator

kokbent commented Nov 7, 2024

Copied from another chat:

or you thinking of maximum flexibility: if for whatever reason run_task.py has three arguments, I can then flexibly csv of three columns to control this?

This is good and a bit more future proofing yeah

@arik-shurygin
Copy link
Collaborator Author

edit: breaking this into two separate issues, --explicit flag will now be tracked here: #9

@arik-shurygin arik-shurygin changed the title add --scenarios flag add --scenarios flag Nov 7, 2024
@arik-shurygin
Copy link
Collaborator Author

CLOSED BY #14, explicit mode covers all use cases for this sort of functionality anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants