rename function and related tests

CDCgov · Nov 22, 2024 · 0638326 · 0638326
1 parent fd5554e
commit 0638326
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/messages/SendMessageHelper.java b/etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/messages/SendMessageHelper.java
@@ -37,7 +37,7 @@ public void savePartnerMetadataForInboundMessage(PartnerMetadata partnerMetadata
         }
     }
 
-    public void saveReportIds(String inboundReportId, String outboundReportId) {
+    public void saveOutboundReportId(String inboundReportId, String outboundReportId) {
         if (outboundReportId == null || inboundReportId == null) {
             logger.logWarning(
                     "Inbound and/or outboundReportId is null so not saving metadata for sent result");

diff --git a/etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/orders/SendOrderUseCase.java b/etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/orders/SendOrderUseCase.java
@@ -49,6 +49,6 @@ public void convertAndSend(final Order<?> order, String inboundReportId)
 
         sendMessageHelper.linkMessage(inboundReportId);
 
-        sendMessageHelper.saveReportIds(inboundReportId, outboundReportId);
+        sendMessageHelper.saveOutboundReportId(inboundReportId, outboundReportId);
     }
 }
diff --git a/etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/results/SendResultUseCase.java b/etor/src/main/java/gov/hhs/cdc/trustedintermediary/etor/results/SendResultUseCase.java
@@ -50,6 +50,6 @@ public void convertAndSend(Result<?> result, String inboundReportId)
 
         sendMessageHelper.linkMessage(inboundReportId);
 
-        sendMessageHelper.saveReportIds(inboundReportId, outboundReportId);
+        sendMessageHelper.saveOutboundReportId(inboundReportId, outboundReportId);
     }
 }
diff --git a/...rc/test/groovy/gov/hhs/cdc/trustedintermediary/etor/messages/SendMessageHelperTest.groovy b/...rc/test/groovy/gov/hhs/cdc/trustedintermediary/etor/messages/SendMessageHelperTest.groovy
@@ -74,38 +74,38 @@ class SendMessageHelperTest extends Specification {
         1 * mockLogger.logError(_, _)
     }
 
-    def "saveReportIds works"() {
+    def "saveOutboundReportId works"() {
         given:
         def outboundReportId = "outboundReportId"
         def inboundReportId = "inboundReportId"
         mockOrchestrator.updateMetadataForOutboundMessage(inboundReportId, _ as String) >> { throw new PartnerMetadataException("Error") }
 
         when:
-        SendMessageHelper.getInstance().saveReportIds(inboundReportId, outboundReportId)
+        SendMessageHelper.getInstance().saveOutboundReportId(inboundReportId, outboundReportId)
 
         then:
         1 * mockOrchestrator.updateMetadataForOutboundMessage(_, _)
     }
 
-    def saveReportIds() {
+    def saveOutboundReportId() {
         given:
         def inboundReportId = "inboundReportId"
 
         when:
-        SendMessageHelper.getInstance().saveReportIds(null, inboundReportId)
+        SendMessageHelper.getInstance().saveOutboundReportId(null, inboundReportId)
 
         then:
         1 * mockLogger.logWarning(_)
     }
 
-    def "saveReportIds should log error and continues when updateMetadataForOutboundMessage throws error"() {
+    def "saveOutboundReportId should log error and continues when updateMetadataForOutboundMessage throws error"() {
         given:
         def outboundReportId = "outboundReportId"
         def inboundReportId = "inboundReportId"
         mockOrchestrator.updateMetadataForOutboundMessage(inboundReportId, _ as String) >> { throw new PartnerMetadataException("Error") }
 
         when:
-        SendMessageHelper.getInstance().saveReportIds(inboundReportId, outboundReportId)
+        SendMessageHelper.getInstance().saveOutboundReportId(inboundReportId, outboundReportId)
 
         then:
         1 * mockLogger.logError(_, _)