From 5ae6a2722d53c3ba1d628ee877ef3f7674f2309f Mon Sep 17 00:00:00 2001 From: Basilio Bogado <541149+basiliskus@users.noreply.github.com> Date: Tue, 19 Nov 2024 07:16:12 -0800 Subject: [PATCH] Update automated test tasks to run on EST timezone (#1588) * Updated automated test tasks to run on PST timezone * Cleanup * Updated to use Central Standard Time * Changed time zone to EST * Added a note in the readme calling out the timezone possible issue --- .github/workflows/automated-staging-test-run.yml | 2 +- .github/workflows/automated-staging-test-submit.yml | 2 +- rs-e2e/README.md | 5 ++++- .../cdc/trustedintermediary/rse2e/AzureBlobFileFetcher.java | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/automated-staging-test-run.yml b/.github/workflows/automated-staging-test-run.yml index ec669b045..ccfafc56e 100644 --- a/.github/workflows/automated-staging-test-run.yml +++ b/.github/workflows/automated-staging-test-run.yml @@ -2,7 +2,7 @@ name: Automated Staging Test - Run integration tests on: schedule: - - cron: "0 2 * * 2-6" # Tuesday to Saturday at 2am UTC - two hours after `automated-staging-test-submit` runs + - cron: "0 7 * * 2-6" # Tuesday to Saturday at 2am EST (7am UTC) - two hours after `automated-staging-test-submit` runs workflow_dispatch: jobs: diff --git a/.github/workflows/automated-staging-test-submit.yml b/.github/workflows/automated-staging-test-submit.yml index 412bcd66d..0733accfa 100644 --- a/.github/workflows/automated-staging-test-submit.yml +++ b/.github/workflows/automated-staging-test-submit.yml @@ -2,7 +2,7 @@ name: Automated Staging Test - Submit Messages on: schedule: - - cron: "0 0 * * 2-6" # Tuesday to Saturday at Midnight UTC + - cron: "0 5 * * 2-6" # Tuesday to Saturday at Midnight EST (5am UTC) workflow_dispatch: jobs: diff --git a/rs-e2e/README.md b/rs-e2e/README.md index 3037887a6..fa457a8cb 100644 --- a/rs-e2e/README.md +++ b/rs-e2e/README.md @@ -6,7 +6,10 @@ Intermediary and ReportStream. It's scheduled to run daily using the Information on how to set up the sample files evaluated by the tests can be found [here](/examples/Test/Automated/README.md) -**Note**: the output files generated by the framework are stored in an Azure blob storage container. Every time the tests are run, the files are moved to a folder with the year/month/day format for better organization. The files are retained in the container for 90 days before being deleted +## Important Notes + +- The output files generated by the framework are stored in an Azure blob storage container. Every time the tests are run, a cleanup task moves the files to a folder with the year/month/day format for better organization. The files are retained in the container for 90 days before being deleted +- The code that organizes the files is using EST time zone. This means that if you are in PST, you may run into an issue if you submit a run before 9 PM PST and then run the tests after 9pm. You'd need to make sure to run both tasks before or after 9pm so the files are where they are expected to be ## Running the tests diff --git a/rs-e2e/src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/AzureBlobFileFetcher.java b/rs-e2e/src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/AzureBlobFileFetcher.java index ceefe5c4f..4d9a3a478 100644 --- a/rs-e2e/src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/AzureBlobFileFetcher.java +++ b/rs-e2e/src/main/java/gov/hhs/cdc/trustedintermediary/rse2e/AzureBlobFileFetcher.java @@ -17,7 +17,8 @@ */ public class AzureBlobFileFetcher implements FileFetcher { - private static final ZoneId TIME_ZONE = ZoneOffset.UTC; + // Using Eastern Standard Time as all or most contributors are in the US + private static final ZoneId TIME_ZONE = ZoneOffset.of("-05:00"); private static final int RETENTION_DAYS = 90; private static final String CONTAINER_NAME = "automated";