ReportStream ORM/OML Transformations Losing Data #900
Comments
|
While reviewing AL test order scenarios output, I found that these fields were missing in the output OML |
|
Original list of missing fields: - OBX-3
|
JohnNKing
changed the title
|
PR in RS: CDCgov/prime-reportstream#15910. The PR has been merged into this branch: |
|
This is the E2E output of the sample message linked in the summary when run against the |
|
ReportStream HL7 to FHIR output of https://github.com/CDCgov/trusted-intermediary/tree/main/examples/MN/003_MN_ORM_O01_NBS.hl7 when run on the OML-Updates-Base feature branch: |
|
I submitted |
|
The 2nd OBR is being dropped because 003_MN_ORM_O01_NBS.hl7 isn't a valid ORM per HL7 V2.5.1. |
|
@basiliskus @GilmoreA6 Can you add that task above? Can you also review the other tasks and check off the ones that are complete? |
|
@brick-green added it |
|
@brick-green there is a task "Look into possibility of adding assertions in the RS Integration Test framework to catch mapping issues" to me that also seems like a separate issue, since this ticket is specifically about validating the RS mappings and reporting gaps, thoughts? |
|
The integration testing will be broken out into a new ticket(s). Remaining work is removing the transformation file. |
|
Added this PR in RS to remove the |
|
Discussed in Stream 2 Refinement in relation to #472; we're assuming at this point that SPM will be provided, which would provide an alternate means of getting the info from OBR-15. |
|
PR to remove |
|
Moving back to Review / QA until the ReportStream work has been merged (to main) and deployed to staging. |
|
@JohnNKing If not yet captured, we need stories created for:
|
|
NK1 work is outlined in #1547 |
|
@jbiskie Did you or someone else try changing the MSH.9 to OML then seeing what happens? |
@GilmoreA6 Am I recalling correctly that you talked about doing this? |
|
@brick-green @jbiskie yes, although I'm not sure what it tells us other than OML message mapping exists and works. We received new test messages today from Ochsner which appear a lot more valid than the previous test messages (segments are in the correct order), so we should see what is missing by running those through as ORMs and OMLs. |
|
Putting the new LA order ORM messages through ReportStream changing MSH-9 from "ORM_001^ORM_001" to "OML^O21^OML_O21" results in an OML message that is complete except for the following missing segments/fields: Missing Segments: Missing Fields The missing fields are mostly (if not entirely) due to them not existing in the HL7 v2 2.5.1 standards |
|
Ochsner made the change to MSH.9 and emailed a new message!! Can we get a quick test in with this one? @jbiskie @GilmoreA6 |
|
@brick-green it looks like ReportStream throws an error if MSH-9-3 is not populated. {"error": "Internal error at 2024-11-15T17:46:23.069054272Z"} |
|
Got it. I'll let them know we also need "OML_021" in MSH-9.3
…On Fri, Nov 15, 2024 at 11:47 AM James Gilmore ***@***.***> wrote:
@brick-green <https://github.com/brick-green> it looks like ReportStream
throws an error if MSH-9-3 is not populated.
{"error": "Internal error at 2024-11-15T17:46:23.069054272Z"}
—
Reply to this email directly, view it on GitHub
<#900 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUSCFDLOKQDLESIJB2V3NML2AYXRHAVCNFSM6AAAAABDQLQJNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZZGU4DONJUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I know RS uses MSH-9.3 to identify the message type, so that's more important to have than MSH-9.1/2 |
|
Reason for Blocked Tagged: This card depends on PR https://github.com/CDCgov/prime-reportstream/pull/16539/files which is not yet merged |
|
One last PR should be open soon to merge changes into main. The work is being tracked in this story: CDCgov/prime-reportstream#16065 |
|
draft PR for merging into main has been started CDCgov/prime-reportstream#16659 |
|
unblocking since RS merged the OML/ORM changes to main. Need to retest with main branch. |
|
After the OML branch has been merged to main, here are the current missing segments/fields Missing Segments: Missing Fields |
|
So IN1, GT1, and PD1 is ticketed. Created new ticket for the remaining missing fields listed above. Any remaining tasks for this ticket? |
|
@brick-green I don't think so, I will move to done |
Bug
Describe the Bug
ReportStream's ORM to FHIR and FHIR to OML transformations are losing data from a variety of fields, including:
I suspect this was introduced by: CDCgov/prime-reportstream#12718
For more details, see https://slack.com/archives/C048S3GPSQG/p1707861774688789
Also ensure an error isn't caused when the order has no OBX segments. (i.e. make OBX not required for ORM messages). Potentially relevant: https://github.com/CDCgov/prime-reportstream/blob/0eb5b42c5a8ccb2d7876fbee7441c790eaf5b828/prime-router/src/main/resources/metadata/hl7_mapping/OML_O21/OML_O21-base.yml#L62
Recently transformed ORM (from 9/11/2024): https://www.slack.com/archives/C044P2CBEKS/p1726088886147019?thread_ts=1726088335.991899&cid=C044P2CBEKS
Impact
ORM orders are lacking key pieces of information for NBS.
To Reproduce
Expected Behavior
Expected HL7 output should be the following (or equivalent):
Tasks
- [ ] Look into possibility of adding assertions in the RS Integration Test framework to catch mapping issuesScreenshots
n/a
Logs
n/a
Version
Current master branch
Additional Context
n/a
The text was updated successfully, but these errors were encountered: