ADRs: Filling in impact sections for 001 - 006

[tjohnson7021]

Filling in Impacts of ADRs that are missing an 'Impact' section

• This PR covers filling in the impact sections for ADRs 001-006 so that it is understood why the decision was made at the time and what the concerns were.
• An adr formatting guide adr-guidelines.md was also created and added to the repo in this PR.

NOTE: When you review, please keep in mind, I am using a mix of general research and experience to fill in these sections, so they may be lacking context-specific impacts of which I am unaware.

Issue #1247

Checklist

• I have updated the documentation accordingly

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 1247 - Partially compliant Fully compliant requirements: Complete the "Impact" section for previously completed ADRs. Not compliant requirements: Create PRs for ADRs in batches for cleaner review.

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Content Duplication The 'Impact' section appears to have content that is very similar to the 'Positive' and 'Negative' subsections, which might be redundant. Verbose Code The 'Negative' impact about verbose code could be more specific about how it affects development time or maintenance.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud