Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused data source #1602

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Remove unused data source #1602

merged 3 commits into from
Nov 21, 2024

Conversation

pluckyswan
Copy link
Contributor

@pluckyswan pluckyswan commented Nov 21, 2024

Description

Remove unused data source azuread_service_principal from db.tf. Successfully deployed in internal.

Issue

#1425

Checklist

Note: You may remove items that are not applicable

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

1425 - Fully compliant

Fully compliant requirements:

  • Remove azuread_service_principal from db.tf
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link

sonarcloud bot commented Nov 21, 2024

@pluckyswan pluckyswan merged commit 4e003ff into main Nov 21, 2024
17 checks passed
@pluckyswan pluckyswan deleted the db-terraform-fix branch November 21, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants