Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more context to readme #1605

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Adding more context to readme #1605

merged 6 commits into from
Nov 25, 2024

Conversation

basiliskus
Copy link
Contributor

@basiliskus basiliskus commented Nov 22, 2024 •
edited
Loading

Description

  • Added instructions on how to test new assertions from a new branch/PR
  • Added more context on how to run tests

Issue

#1540

@github-actions GitHub Actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

1540 - Partially compliant

Fully compliant requirements:

  • Instructions on how to test new assertions from a new branch/PR

Not compliant requirements:

  • Checking for internal open/close quotes in json
  • Making tests fail on purpose as a gut check that they're running as expected/not passing because they're being filtered out
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Missing Information
The PR does not address all the requirements specified in the ticket, particularly checking for quotes in JSON and making tests fail intentionally.

github-actions[bot]
github-actions bot reviewed Nov 22, 2024
View reviewed changes
rs-e2e/README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@basiliskus basiliskus marked this pull request as ready for review November 25, 2024 19:42
luis-pabon-tf
luis-pabon-tf requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@luis-pabon-tf luis-pabon-tf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big improvement over the original doc, only had one suggestion

rs-e2e/README.md Show resolved Hide resolved
pluckyswan
pluckyswan reviewed Nov 25, 2024
View reviewed changes
rs-e2e/README.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@basiliskus basiliskus merged commit 1039b4c into main Nov 25, 2024
17 checks passed
@basiliskus basiliskus deleted the story/1540/add-docs branch November 25, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@luis-pabon-tf luis-pabon-tf luis-pabon-tf approved these changes

@pluckyswan pluckyswan Awaiting requested review from pluckyswan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basiliskus @luis-pabon-tf @pluckyswan