Use inject for non singleton class

[jorg3lopez]

Description

Under construction

Issue

Add a link to the issue here. Consider using
closing keywords
if the this PR isn't for a story (stories will be closed through different means).

Checklist

• I have added tests to cover my changes
• I have added logging where useful (with appropriate log level)
• I have added JavaDocs where required
• I have updated the documentation accordingly

Note: You may remove items that are not applicable

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Exception Handling The method 'injectIntoField' throws a generic IllegalArgumentException for any exception during field injection. This could mask different issues like security or logical errors which might need different handling. Dependency Injection The use of 'ApplicationContext.injectIntoNonSingleton(this)' within the constructor might lead to issues with incomplete construction if the injected dependencies themselves depend on the partially constructed object.

[github-actions]

Consider adding specific exception handling for different types of injection failures. This could improve the robustness and security of the application by providing clearer error messages and handling specific cases differently. [important]

[github-actions]

To avoid potential issues with circular dependencies and incomplete construction, consider using a factory or builder pattern to manage object creation and dependency injection, rather than injecting dependencies directly in the constructor. [important]

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Prevent potential NullPointerException by checking if instance is null before setting a field Ensure that injectIntoField checks for null instance before attempting to set the field, to prevent NullPointerException. shared/src/main/java/gov/hhs/cdc/trustedintermediary/context/ApplicationContext.java [82] -field.set(instance, fieldImplementation); +if (instance != null) { + field.set(instance, fieldImplementation); +} Suggestion importance[1-10]: 8 Why: This suggestion correctly identifies a potential NullPointerException risk in the code and provides a solution to prevent it, enhancing the robustness of the method.	8
	Enhance robustness by ensuring the annotation parameter is a valid subclass of Annotation Modify getFieldsAnnotatedWithInstance to handle the case where the annotation parameter is not a subclass of Annotation, to avoid a potential ClassCastException. shared/src/main/java/gov/hhs/cdc/trustedintermediary/context/Reflection.java [36] -.filter(field -> field.isAnnotationPresent(annotation.asSubclass(Annotation.class))) +.filter(field -> Annotation.class.isAssignableFrom(annotation) && field.isAnnotationPresent(annotation.asSubclass(Annotation.class))) Suggestion importance[1-10]: 7 Why: The suggestion accurately addresses a potential ClassCastException by checking if the annotation parameter is a valid subclass of Annotation before casting, thus improving the method's safety.	7
General	Improve stability by handling potential injection failures gracefully Add error handling for the injectIntoNonSingleton method in the constructor to manage potential injection failures gracefully. shared/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiFhirResource.java [16] -ApplicationContext.injectIntoNonSingleton(this); +try { + ApplicationContext.injectIntoNonSingleton(this); +} catch (Exception e) { + logger.error("Injection failed", e); +} Suggestion importance[1-10]: 6 Why: This suggestion proposes adding error handling around the injection process to manage failures more gracefully, which is a good practice for improving the reliability of the application.	6
	Provide clearer diagnostics by handling null implementations more informatively Add logging or throw a more specific exception when fieldImplementation is null, to provide clearer diagnostics when injection fails. shared/src/main/java/gov/hhs/cdc/trustedintermediary/context/ApplicationContext.java [76-77] if (fieldImplementation == null) { - return; + throw new IllegalStateException("No implementation found for " + fieldType); } Suggestion importance[1-10]: 5 Why: The suggestion to throw a more specific exception when an implementation is not found is beneficial for debugging and understanding injection failures, although it could be improved by also including logging before throwing the exception.	5

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
76.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud